While testing running the test suite under Py3.7 on windows we hit an
issue installing botocore at the version it was at.
With this newer version of boto3 which also pulls in a newer version of
botocore we got past the issue.
In #20602 we added the ability to change ARPCHECK in network settings.
This was missing and later added in RH7, but was missing from RH8, since
RH8 support was added before we updated the RH7 support.
This fixes#57047
Since the master branch no longer supports Python 2, and many distros
still default /usr/bin/python to Python 2, this commit changes the
scripts to explicitly call Python 3.
Since volumes in a virtual storage pool of type 'disk' are partitions,
then need to be named after the disk name with sequential numbers rather
than using the VM and disk names.
Also, the format passed by the user is the one used when creating the volume.
However in the VM definition for logical and disk volumes, the format should
be set to raw.
libvirt doesn't support attaching RBD storage pool volumes to a VM.
For instance, a disk with such a source is invalid:
<source pool='rbd-pool' volume='rbd-volume'/>
And needs to be replaced with:
<source protocol="rbd" name="rbd-pool-name/rbd-volume">
<host name="hostname" port="7000"/>
<auth username='myuser'>
<secret type='ceph' usage='mypassid'/>
</auth>
</source>
This means that we need to fetch the connection data from the pool
definition and convert the volume disk definition into a network one
when creating the VM.
This also means that when purging the VM we need to search for the
pool by looking in every pool's XML to delete the volume.
