* Fixing various redirected links
* Change links to https
* Reintroduced macro link reference
* Change man page to original at master; revert added line
* Add method to remove circular references in data objects and add test
* remove trailing whitespace
* Blacken changed files
Co-authored-by: xeacott <jeacott@saltstack.com>
Co-authored-by: Frode Gundersen <fgundersen@saltstack.com>
Co-authored-by: Daniel A. Wozniak <dwozniak@saltstack.com>
* Combine proxy and native minion workflows for NXOS
- Normalize SSH and NX-API proxy minion workflows
- Add NX-API over unix domain socket support for native minions
* Fix typo
* Fix states correct_roles bug
* Add comment clarification for nxos states
* Fix lint issues
* Address python3 incompatibility
* Fix additional lint issues
* Disable pylint W1699 warning
* Use new style class syntax
* Correct typo
* Fix nxos grains
* Pass data to grains function
* Return nxos grains key
* Protect nxos grain with proper __virtual__() check
The changes in PR #49676 made the following stacktrace occur when running
on a system that doesn't have the proper NXOS/NXAPIClient settings exposed:
```
[CRITICAL] Failed to load grains defined in grain file nxos.system_information in function <function system_information at 0x3aeb758>, error:
Traceback (most recent call last):
File "/testing/salt/loader.py", line 773, in grains
ret = funcs[key](**kwargs)
File "/testing/salt/grains/nxos.py", line 36, in system_information
data = salt.utils.nxos.version_info()
File "/testing/salt/utils/nxos.py", line 318, in version_info
client = NxapiClient()
File "/testing/salt/utils/nxos.py", line 78, in __init__
raise RuntimeError("No host specified and no UDS found at {0}\n".format(self.NXAPI_UDS))
RuntimeError: No host specified and no UDS found at /tmp/nginx_local/nginx_1_be_nxapi.sock
local:
True
```
We need to protect the grains from loading when the settings are missing.
* Initial nxos_upgrade changes
* Revert "Initial nxos_upgrade changes"
This reverts commit e17ca19fbc.
* New NX-OS salt minion install doc
* Add guestshell sync information
* Initial nxos_upgrade changes
* Initial nxos_upgrade changes
* Revert "Initial nxos_upgrade changes"
This reverts commit e17ca19fbc.
* Revert "Initial nxos_upgrade changes"
This reverts commit e17ca19fbc.
* Add nxos to index.rst
* New nxos_upgrade execution and state modules
* Added NXOS UT support - initially for nxos_upgrade.py
* Resolved one pylint 'old class style' issue. Excluding 'nxos' sub-directory under tests/unit/modules
* Add __init__.py file to treat directory as a package directory.
* Addressed PR comments.
* Removed pylint disable-msg that was only applicable to python 3+
* Document NAPALM installation inside Guestshell
Adding step-by-step guide to install NAPALM inside of the NXOS Guestshell.
* show and sendline method fixes
* Update doc for starting minion in nxos GuestShell
* Revert show method changes
* Revert sendline method doc changes
* Resolve lint errors
* Remove nxos guestshell napalm references
This work is delayed so removing the references
* Address review comments
* Address salt style guide comment
* Doc and module updates
* Initial nxos module and proxy unit tests
* Additional nxos module and proxy unit tests
* Add nxos state unit tests
* Add tests for replace function
* Bug fixes
* Fix test_check_password_password_encrypted_false test
* Add test_config_nxos_error_ssh test
* remove opts modification in init
* reduce scope of variable to function where it's used
* minor nxos cleanup - raise instead of exit, use named kwargs
* use create_autospec in place of raw mocks
* _init_ssh's raise is now caught by ping
* allow gen_hash to work on any system
* change no_save_config option to save_config
* update set_password to work with updated gen_hash
* passing an invalid algorithm to pycrypto.hash raises
* blacken nxos-related files
* _fallback_gen_hash also works without a password
* remove debugging line, improve error message
* lint and black
* nxos docfix
* remove unused variable
* Review comments addressed
* mark old nxos functions as deprecated
* black
* remove unused variables
* clean up arguments
* simplify save_config logic
* minor doc cleanup
* make sendline with a list of commands reliably work
* Update various doc index files for nxos_upgrade
* Fix a few bugs in nxos proxy and execution modules
* doc indent fix
Co-authored-by: mikewiebe <mwiebe@cisco.com>
Co-authored-by: rallytime <nicole@saltstack.com>
Co-authored-by: Thomas Stoner <tmstoner@cisco.com>
Co-authored-by: tstoner <33665760+tstoner@users.noreply.github.com>
Co-authored-by: Chris Van Heuveln <cvanheuv@cisco.com>
The current state of the docs, due to incorrectly-formatted RST, puts
the recently-added ``warnings`` argument for the
``configurable_test_state`` function in a "Warning" block. This fixes
that, and also moves some ``versionadded``/``versionchanged`` blocks to
conform with common usage elsewhere in the salt docs.
This also fixes some incorrect capitalization in error messages, and
incorrect usage of single-backtick (should be double-backtick).
Finally, a minor tweak to ``configurable_test_state``: The "random"
functionality is now case-insensitive.
