* add cmd state features to state.py
also dry git state
* dry docker_container
* update docker test
* correct integration test
* clarity improvement
* lint and test fixes
* correct test
* global req updates
* doc update
* doc updates
* remove unused mac requisite implementation
* other macpackage cleanup
* handle missing user in runas
* add test cases unless/onlyif exception handling
* fix macpackage tests
* fix typo
* Fixing various redirected links
* Change links to https
* Reintroduced macro link reference
* Change man page to original at master; revert added line
* Combine proxy and native minion workflows for NXOS
- Normalize SSH and NX-API proxy minion workflows
- Add NX-API over unix domain socket support for native minions
* Fix typo
* Fix states correct_roles bug
* Add comment clarification for nxos states
* Fix lint issues
* Address python3 incompatibility
* Fix additional lint issues
* Disable pylint W1699 warning
* Use new style class syntax
* Correct typo
* Fix nxos grains
* Pass data to grains function
* Return nxos grains key
* Protect nxos grain with proper __virtual__() check
The changes in PR #49676 made the following stacktrace occur when running
on a system that doesn't have the proper NXOS/NXAPIClient settings exposed:
```
[CRITICAL] Failed to load grains defined in grain file nxos.system_information in function <function system_information at 0x3aeb758>, error:
Traceback (most recent call last):
File "/testing/salt/loader.py", line 773, in grains
ret = funcs[key](**kwargs)
File "/testing/salt/grains/nxos.py", line 36, in system_information
data = salt.utils.nxos.version_info()
File "/testing/salt/utils/nxos.py", line 318, in version_info
client = NxapiClient()
File "/testing/salt/utils/nxos.py", line 78, in __init__
raise RuntimeError("No host specified and no UDS found at {0}\n".format(self.NXAPI_UDS))
RuntimeError: No host specified and no UDS found at /tmp/nginx_local/nginx_1_be_nxapi.sock
local:
True
```
We need to protect the grains from loading when the settings are missing.
* Initial nxos_upgrade changes
* Revert "Initial nxos_upgrade changes"
This reverts commit e17ca19fbc.
* New NX-OS salt minion install doc
* Add guestshell sync information
* Initial nxos_upgrade changes
* Initial nxos_upgrade changes
* Revert "Initial nxos_upgrade changes"
This reverts commit e17ca19fbc.
* Revert "Initial nxos_upgrade changes"
This reverts commit e17ca19fbc.
* Add nxos to index.rst
* New nxos_upgrade execution and state modules
* Added NXOS UT support - initially for nxos_upgrade.py
* Resolved one pylint 'old class style' issue. Excluding 'nxos' sub-directory under tests/unit/modules
* Add __init__.py file to treat directory as a package directory.
* Addressed PR comments.
* Removed pylint disable-msg that was only applicable to python 3+
* Document NAPALM installation inside Guestshell
Adding step-by-step guide to install NAPALM inside of the NXOS Guestshell.
* show and sendline method fixes
* Update doc for starting minion in nxos GuestShell
* Revert show method changes
* Revert sendline method doc changes
* Resolve lint errors
* Remove nxos guestshell napalm references
This work is delayed so removing the references
* Address review comments
* Address salt style guide comment
* Doc and module updates
* Initial nxos module and proxy unit tests
* Additional nxos module and proxy unit tests
* Add nxos state unit tests
* Add tests for replace function
* Bug fixes
* Fix test_check_password_password_encrypted_false test
* Add test_config_nxos_error_ssh test
* remove opts modification in init
* reduce scope of variable to function where it's used
* minor nxos cleanup - raise instead of exit, use named kwargs
* use create_autospec in place of raw mocks
* _init_ssh's raise is now caught by ping
* allow gen_hash to work on any system
* change no_save_config option to save_config
* update set_password to work with updated gen_hash
* passing an invalid algorithm to pycrypto.hash raises
* blacken nxos-related files
* _fallback_gen_hash also works without a password
* remove debugging line, improve error message
* lint and black
* nxos docfix
* remove unused variable
* Review comments addressed
* mark old nxos functions as deprecated
* black
* remove unused variables
* clean up arguments
* simplify save_config logic
* minor doc cleanup
* make sendline with a list of commands reliably work
* Update various doc index files for nxos_upgrade
* Fix a few bugs in nxos proxy and execution modules
* doc indent fix
Co-authored-by: mikewiebe <mwiebe@cisco.com>
Co-authored-by: rallytime <nicole@saltstack.com>
Co-authored-by: Thomas Stoner <tmstoner@cisco.com>
Co-authored-by: tstoner <33665760+tstoner@users.noreply.github.com>
Co-authored-by: Chris Van Heuveln <cvanheuv@cisco.com>
* Fix typos (`the the` > `the`)
It looks like humans aren't only very bad at recognizing a double `the` in a sentence when reading [1], but they're also very good at sneaking them in unintentionally without noticing.
Fix this by running:
```
ack --ignore-dir=doc/man --ignore-dir=doc/topics/releases -i 'the the\W' -l | xargs sed -i 's|the the\(\W\)|the\1|g'
```
[1] Eye movements and word skipping during reading: Effects of word length and predictability: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC3543826/
* Blacken changed files
* Blacken changed files
* Re-add unintentional delete
* Bad merge fix
* Fix broken docstring
* Another try
* pre-commit should pass now?
Co-authored-by: Daniel A. Wozniak <dwozniak@saltstack.com>
Co-authored-by: Wayne Werner <wwerner@saltstack.com>
* Fix typo of additional
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of against
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of amount
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of argument
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of attempt
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of bandwidth
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of caught
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of compatibility
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of consistency
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of conversions
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of corresponding
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of dependent
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of dictionary
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of disabled
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of adapters
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of disassociates
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of changes
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of command
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of communicate
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of community
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of configuration
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of default
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of absence
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of attribute
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of container
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of described
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of existence
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of explicit
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of formatted
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of guarantees
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of hexadecimal
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of hierarchy
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of initialize
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of label
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of management
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of mismatch
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of don't
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of manually
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of getting
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of information
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of meant
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of nonexistent
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of occur
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of omitted
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of normally
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of overridden
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of repository
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of separate
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of separator
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of specific
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of successful
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of succeeded
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of support
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of version
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of that's
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of "will be removed"
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of release
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of synchronize
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of python
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of usually
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of override
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of running
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of whether
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of package
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of persist
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of preferred
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of present
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix typo of run
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of "allows someone to..."
"Allows to" is not correct English. It must either be "allows someone
to" or "allows doing".
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of "number of times"
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of msgpack
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of daemonized
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of daemons
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of extemporaneous
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of instead
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
* Fix spelling mistake of returning
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
dh_sphinxdoc (used for building the documentation in the Debian package)
searches for script lines and expect the type set to text/javascript.
Otherwise dh_sphinxdoc won't find the scripts.
Therefore mark the JavaScript scripts explicitly as text/javascript.
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
when https://github.com/saltstack/salt/issues/22370 was introduced it
actually removed functionality, as sometimes it desirable to onfail if
ALL of the listed requisites are failure. This adds back an 'onfail_all'
form that allows for this behavior (it would make more sense to have
onfail default to OR logic, but that would break backcompat, so we add
a new form instead).
