salt/changelog
Jonas Maurus 155197dd49
Fix #55262 (mixing of stderr and stdout in cmd.run return value leads to errors in iptables/nftables saved rules) (#58573)
* Fixing saltstack/salt#55262 by using cmd correctly

This commit attemts to fix saltstack/salt#55262 by ensuring that output
from stdout and stderr isn't mixed in `iptables.save`. It also changes
other invocations of `cmd.*` by using `cmd.run_stdout` and
`com.run_stderr` respectively to what the iptables function expects.

I found some other issues here, where for example `iptables.new_chain`
returns `True` when successful and `iptables.set_policy` returns `False`
when successful. But that's for a separate patch to fix.

* adding changelog entry

* run pre-commit hooks

* remove unused import

* update iptables.check to use stdout

* update tests

* explicitly use stdout for help output and version checking, too

* linting/blacken test_iptables

* add mocks for run_stdout and run_stderr where necessary

* blacken test_iptables again

* linting test_iptables

* empty commit to trigger PR rebuild to fix spurious error report

Co-authored-by: Megan Wilhite <megan.wilhite@gmail.com>
2021-08-26 14:19:38 -04:00
..
.keep Add changelog keep file 2020-06-06 20:59:24 -07:00
20789.fixed Fix 20789 - Window's user creation and password policy requirements (#59563) 2021-04-02 06:26:03 -04:00
44330.fixed Skip subnets that contain no tags to bypass KeyError 2021-07-15 11:11:47 -04:00
46942.fixed Add changelog for 46942 2021-04-02 06:20:19 -04:00
47628.fixed Fixing the state aggregation system to properly handle requisities (#60604) 2021-08-12 14:38:23 -04:00
47969.fixed Fix windows file recurse with clean true (#60415) 2021-08-18 21:27:13 -07:00
48947.fixed Adding changelog and adding tests for changes 2021-04-22 10:09:53 -04:00
49115.fixed Removing extra newline from changelog. removing debugging messages from conftest.py. 2021-06-30 13:37:22 -04:00
49130.added Added changelog 2021-08-24 07:07:49 -04:00
50313.fixed Address leaks in fileserver caused by git backends 2021-06-23 08:11:53 -04:00
50597.added Simplifies changelog entry 2021-04-05 14:45:12 -04:00
50695.fixed Adding changlog entry 2021-07-13 08:44:10 -04:00
50979.fixed Handles FileNotFoundError exception in shadow.info 2021-05-07 15:00:59 -07:00
51382.fixed Added changelog entry 2021-03-22 14:30:09 -04:00
51490.added Netbox pillar enhancements - Virtual Machines, Interfaces, IP Addresses, Documentation (#59500) 2021-08-25 16:40:09 -07:00
52288.fixed add changelog file 2021-04-02 06:37:31 -04:00
53868.fixed Added tests for LXC grains and changelog entries 2021-06-02 06:45:59 -04:00
54224.fixed Add changelog entry 2021-05-19 14:21:34 -04:00
55262.fixed Fix #55262 (mixing of stderr and stdout in cmd.run return value leads to errors in iptables/nftables saved rules) (#58573) 2021-08-26 14:19:38 -04:00
56924.fixed Update pcs support for > 0.10 (#60257) 2021-08-24 14:04:15 -04:00
57111.changed Return the nginx version without prefix 2021-05-26 14:06:08 -04:00
57127.fixed Add changelog entry for openstack ignore_cidr option 2021-04-21 12:38:47 -07:00
57182.changed Update 57182.changed 2021-08-26 08:04:22 -04:00
57473.fixed Added changelog entry for fix 2021-06-28 11:36:33 -04:00
57490.fixed Added changelog for the fix 2021-03-30 13:22:13 -04:00
57733.fixed Add changelog for #57733 2021-08-06 17:08:46 -07:00
57786.fixed Fixing various functions in the file state module that use user.info (#60502) 2021-08-24 11:43:50 -04:00
57881.changed Parsing Epoch out of version provided during pkg remove (#57881) 2021-04-22 14:02:07 -04:00
57995.fixed Add changelog file 2021-08-26 14:15:57 -04:00
58519.added Add changelog entry 58519.added 2021-08-24 12:11:21 -04:00
58585.added Features/vault enterprise (#58586) 2021-04-29 11:11:21 -04:00
58600.fixed Adding misisng changelog for PR https://github.com/saltstack/salt/pull/60448 which fixed issue #58600 2021-07-20 12:43:59 -04:00
58713.added feat: add unit test for utils/boto3mod 2021-05-05 07:14:34 -04:00
58742.added feat: added allow_one_of() and require_one_of() decorators 2021-03-30 14:23:15 -04:00
58881.fixed Update changelog to reflect changes. 2021-08-19 11:49:44 -04:00
58915.fixed Add changelog for 58915 2021-04-01 06:27:03 -04:00
58944.fixed add changelog entry 2021-08-18 08:40:04 -04:00
58956.fixed Add changelog entry 2021-04-21 12:44:19 -07:00
59001.fixed Fix Xen DomU detection in grains 2021-04-21 12:39:44 -07:00
59026.changed changelog file update 2021-04-30 13:05:45 -07:00
59063.fixed Fix 59063 (#59435) 2021-08-24 11:35:20 -04:00
59079.removed update wording in changelog 2021-03-18 10:42:29 -04:00
59193.added Added changelog 2021-04-30 13:07:02 -07:00
59269.fixed Add changelog 2021-03-30 13:24:10 -04:00
59332.fixed Add grains fix for Astra Linux (#59353) 2021-04-05 07:16:42 -04:00
59337.fixed Adding changelog. 2021-08-12 14:37:03 -04:00
59338.fixed Fixed zabbix mod get connection data from pillar 2021-03-30 13:23:28 -04:00
59354.fixed Add changelog 2021-04-01 06:28:37 -04:00
59396.fixed update changelog file 2021-08-04 12:55:58 -04:00
59398.added Netbox pillar enhancements - Virtual Machines, Interfaces, IP Addresses, Documentation (#59500) 2021-08-25 16:40:09 -07:00
59416.fixed virt: don't add spicevmc channel to Xen VMs 2021-03-17 07:25:08 -04:00
59424.fixed Add changelog 2021-06-02 06:48:42 -04:00
59490.fixed Clear network interface cache when grains are requested or refreshed (#60130) 2021-08-25 16:31:01 -07:00
59573.fixed Added tests for LXC grains and changelog entries 2021-06-02 06:45:59 -04:00
59581.fixed Add changelog entry 2021-04-02 15:28:22 -07:00
59682.added Adding preliminary support for Rocky. (#59682) 2021-04-07 06:49:23 -04:00
59686.fixed add aliyun linux support and set alinux as redhat family 2021-03-24 10:56:41 -04:00
59692.fixed virt.network_update: handle missing ipv4 netmask attribute 2021-04-21 12:45:34 -07:00
59739.fixed Fix virt states results when no change happened 2021-05-11 14:24:54 -04:00
59744.fixed Add changelog for 59744 2021-04-08 16:12:15 -07:00
59754.fixed Fix mysql module to return bytes instead strings 2021-08-10 13:47:18 -04:00
59769.fixed Handle gpt.ini with unix line endings 2021-04-05 14:46:40 -04:00
59792.fixed The `ansiblegate` module now correctly passes keyword arguments to Ansible module calls 2021-06-30 11:39:28 -07:00
59793.fixed Make sure cmdmod._log_cmd handles tuples properly 2021-08-06 21:57:06 -07:00
59831.added Add changelog 2021-03-25 15:55:49 -04:00
59844.fixed Adding changelog. 2021-05-05 14:23:04 -04:00
59847.fixed Add changelog for changes 2021-07-06 09:04:28 -04:00
59864.fixed Add changelog 2021-04-06 17:44:30 -07:00
59865.fixed Update changelog, use basename 2021-07-23 13:06:52 -07:00
59869.removed add distro_arch 2021-04-09 14:54:17 -07:00
59880.fixed Salt api honors --log-file correctly 2021-03-25 14:44:10 -04:00
59882.deprecated feat: stop using utils/boto3_elasticsearch methods 2021-08-17 13:32:24 -04:00
59888.added Added changelog entry 2021-03-31 10:15:40 -07:00
59892.fixed Adding mendel linux 2021-03-30 06:48:15 -04:00
59915.added Changelog rewording 2021-03-31 09:22:01 -07:00
59922.fixed Add changelog for #59922 2021-04-13 14:52:33 -07:00
59932.fixed Better deal with multiple Xen VMs having the same name 2021-07-13 13:15:40 -04:00
59958.fixed fixup nftables.build_rule for saddr/daddr 2021-04-21 12:30:18 -07:00
59961.fixed Add back support to load old entrypoints by iterating instead of type checking 2021-05-13 12:50:29 -04:00
59966.fixed Fix SIGINT with salt-call 2021-04-29 12:37:29 -07:00
60031.fixed Fixes to mysql modules and state modules (#60087) 2021-07-06 13:31:04 -04:00
60033.fixed Fixed firewalld.list_zones for tabbed values 2021-07-07 12:46:26 -04:00
60049.fixed Update 60049.fixed 2021-06-01 07:20:06 -04:00
60061.fixed Updated changelog text 2021-06-24 13:57:27 -04:00
60072.fixed Ensure proper access to the created temporary file 2021-06-28 11:47:56 -07:00
60090.added Adding changelog 2021-08-24 13:40:27 -04:00
60105.fixed Fix the logic in pkgng.latest_version when querying by origin 2021-05-05 14:06:33 -04:00
60108.fixed Fix the logic in pkgng.latest_version when querying by origin 2021-05-05 14:06:33 -04:00
60132.fixed Handle volumes on stopped pools in virt.vm_info 2021-06-04 08:41:02 -04:00
60142.fixed Add changelog 2021-07-23 07:10:35 -04:00
60149.fixed Adding changelog 2021-05-12 06:50:38 -04:00
60168.fixed Adding changelog 2021-05-12 06:53:23 -04:00
60179.fixed Fix ValueError exception in state.show_state_usage 2021-06-23 13:00:23 -04:00
60203.fixed Only show the filename of a URL when something goes wrong (#60489) 2021-08-19 13:43:21 -04:00
60207.fixed Inject the ansible functions into Salt's ansiblegate module. 2021-06-30 11:39:28 -07:00
60229.fixed Add changelog 2021-08-03 14:05:45 -04:00
60232.fixed Added changelog entry for issue 2021-06-28 13:26:28 -04:00
60241.fixed Consolidating beacon configuration mapping code (#60303) 2021-08-24 11:45:19 -04:00
60259.fixed Add missing changelog 2021-06-24 13:33:23 -04:00
60296.fixed Better handle path to block devices in virt.update 2021-08-03 13:55:20 -04:00
60330.fixed The traceback.*_exc() functions do not have an exc argument. 2021-07-14 14:26:08 -04:00
60339.fixed Fix faulty npm.installed state 2021-07-19 12:10:23 -04:00
60340.fixed Reinstated Port option for Junos Proxy with tests 2021-06-24 11:44:33 -04:00
60351.fixed Updates hosts.rm_host tests 2021-06-30 13:37:43 -04:00
60357.fixed Changelog 2021-06-25 13:50:33 -04:00
60398.fixed Fixes to mysql cache (#60447) 2021-08-17 12:29:45 -04:00
60419.fixed virt: use /dev/kvm to detect KVM 2021-07-12 14:22:01 -04:00
60426.fixed Adding changelog. 2021-08-02 14:28:12 -04:00
60461.fixed Adding a changelog 2021-07-06 13:26:46 -04:00
60491.fixed virt: pass emulator when getting domain capabilities from libvirt 2021-07-12 14:22:30 -04:00
60511.deprecated Rename changelog to note deprecation 2021-07-19 14:22:54 -04:00
60512.fixed virt.get_disks: don't fail when a VM disk is missing 2021-08-02 14:24:01 -04:00
60529.fixed Ignore configuration for 'enable_fqdns_grains' for AIX, Solaris and Juniper 2021-07-20 19:51:11 -07:00
60559.fixed Remove check for TIAMAT_BUILD enforcing USE_STATIC_REQUIREMENTS, this is now controled by Tiamat v7.10.1 and above 2021-07-21 13:59:19 -07:00
60565.removed Remove code deprecated until Silicon(3004), the upcoming release. 2021-07-20 07:12:00 -04:00
60585.fixed Fixing changelog. Removing unneeded log message. 2021-08-04 13:11:25 -04:00
60594.fixed Add changelog 2021-07-28 17:47:23 -07:00
60612.added Add detect_remote_minions and remote_minions_port options to detect minions connected on other ports 2021-08-02 07:47:24 -07:00
60617.fixed Add changelog 2021-08-02 06:43:15 -04:00
60669.fixed Bump dep warn from silicon to phosphorous for nxos module (#60660) 2021-08-16 16:11:42 -07:00
60675.fixed Adapt _get_active_provider_name for hetzner (#60675) 2021-08-17 17:50:24 -07:00
60676.fixed Fix the pwd.getpwnam caching issue on macOS user module 2021-08-11 07:06:56 -04:00
60684.fixed Adding changelog. 2021-08-12 13:44:07 -04:00
60749.fixed Fix RuntimeError in process mangager 2021-08-23 12:45:25 -04:00