salt/tests/pytests/unit/runners/test_state.py
Alexander Graul 2c03915529 state.orchestrate_single does not pass pillar=None
Passing a pillar to state.single can results in state functions not
working when they don't accept a pillar keyword argument. One example
where this is the case is salt.wait_for_event. When no pillar is
provided, it does not need to be passed.
2022-10-07 07:32:30 -06:00

40 lines
1.4 KiB
Python

import pytest
from salt.runners import state as state_runner
from tests.support.mock import Mock, patch
@pytest.fixture
def configure_loader_modules():
return {state_runner: {"__opts__": {}, "__jid_event__": Mock()}}
def test_orchestrate_single_passes_pillar():
"""
test state.orchestrate_single passes given pillar to state.single
"""
mock_master_minion = Mock()
mock_state_single = Mock()
mock_master_minion.functions = {"state.single": mock_state_single}
mock_master_minion.opts = {"id": "dummy"}
test_pillar = {"test_entry": "exists"}
with patch("salt.minion.MasterMinion", Mock(return_value=mock_master_minion)):
state_runner.orchestrate_single(
fun="pillar.get", name="test_entry", pillar=test_pillar
)
assert mock_state_single.call_args.kwargs["pillar"] == test_pillar
def test_orchestrate_single_does_not_pass_none_pillar():
"""
test state.orchestrate_single does not pass pillar=None to state.single
"""
mock_master_minion = Mock()
mock_state_single = Mock()
mock_master_minion.functions = {"state.single": mock_state_single}
mock_master_minion.opts = {"id": "dummy"}
with patch("salt.minion.MasterMinion", Mock(return_value=mock_master_minion)):
state_runner.orchestrate_single(
fun="pillar.get", name="test_entry", pillar=None
)
assert "pillar" not in mock_state_single.call_args.kwargs