Some recent change in Salt is now doing the right thing, and calling the
different states with separated args and kwargs. This change trigger a
hidden bug in the __mount_device decorator, that expect those parameter
to be in kwargs, as is happening during the test.
This patch change the way that the wrapper inside the decorator search
for the name and device parameters, first looking into kwargs and later
in args if possible. A new test is introduced to exercise both cases.
Fix#58012
salt-run $server spacewalk.api allows users to run arbitrary Spacewalk
API functions through Salt. These are passed in a namespace.method
notation and may use nested namespaces. Previously only methods in a
top-level namespace were supported.
Fixes https://github.com/saltstack/salt/issues/57442
Co-authored-by: Wayne Werner <wwerner@saltstack.com>
* delete_schedule_conf_on_yaml_parse_error
* delete_schedule_conf_on_yaml_parse_error
* delete_schedule_conf_on_yaml_parse_error
* doc
* changelog
* delete_schedule_conf_on_yaml_parse_error
* delete_schedule_conf_on_yaml_parse_error
* delete_schedule_conf_on_yaml_parse_error
* doc
* changelog
* Add some tests
* Rename instead of remove
* doc
* no sleep
* pylint
* Use direct import instead of __utils__
* Remove __utils__ from other modules __virtual__ func
* Remove py2 code
* Revert boto_ec2
There's a problem with the assign_funcs util that I don't know how to
fix
* Rever boto_sns
There a problems with the assign_funcs util that I don't know how to fix
* Remove py2 code form elbv2
* delete_schedule_conf_on_yaml_parse_error
* delete_schedule_conf_on_yaml_parse_error
* delete_schedule_conf_on_yaml_parse_error
* doc
* changelog
* Add some tests
* Rename instead of remove
* doc
* no sleep
* pylint
* Remove py2
* Fix format strings
* Fix some black
* fix some lint
* Fix failing test
* Added changelogs
* Moved test code of Twangboy, help of DmitryKuzmenko
* Redundant import
* Fix black
* Fix issue with iterator
Co-authored-by: twangboy <slee@saltstack.com>
because the future was generated from tornado.gen.sleep, its eventual timer
still fires regardless of if the future is manually set with set_result. When
set_result is called twice (once manually by saltnado, once by tornado call_later),
a stacktrace like so is thrown:
[ERROR ] Uncaught exception POST / (::1)
Traceback (most recent call last):
File "/home/mphillips81/.pyenv/versions/3.6.5/lib/python3.6/site-packages/tornado/web.py", line 1369, in _stack_context_handle_exception
raise_exc_info((type, value, traceback))
File "<string>", line 3, in raise_exc_info
File "/home/mphillips81/.pyenv/versions/3.6.5/lib/python3.6/site-packages/tornado/stack_context.py", line 314, in wrapped
ret = fn(*args, **kwargs)
File "/home/mphillips81/.pyenv/versions/3.6.5/lib/python3.6/site-packages/tornado/gen.py", line 771, in later
f.set_result(None)
File "/home/mphillips81/.pyenv/versions/3.6.5/lib/python3.6/site-packages/tornado/concurrent.py", line 254, in set_result
self._set_done()
File "/home/mphillips81/.pyenv/versions/3.6.5/lib/python3.6/site-packages/tornado/concurrent.py", line 298, in _set_done
for cb in self._callbacks:
TypeError: 'NoneType' object is not iterable
This patch attempts to fix that.
This patch ensures that the extents file attribute is ignored when
comparing file attributes. This is necessary because this attribute is
set by the underlying file system and can never be reset.
The libvirt xen driver does not handle disk of 'volume' type. We thus
need to convert them into their equivalent using the 'file' or 'block'
type (issue #58333).
* ensure version isn't an int because of yaml parsing
Fix#50899
* Add test for working float version
Add some test to make sure float/int value of version will work
* Add changelog
* Drop six usage and Py2 support
Use dump rather than dumps when storing to the cache, this makes it
symmetric with fetch and more importantly sets use_bin_type so that
loading will be able to distinguish between bytes and str correctly.
In order to handle more parameters in the future, refactor the XML
diffing in virt.update to only require adding entries in a mapping
array.
Using the refactoring the boot parameters are also better handled and we
are thus fixing an issue when updating existing loader parameter. See
the added test case.
virt.init knows how to set the boot device order for a while, but this
feature never came to virt.running. This commit is fixing this omission
and adds it for both virt.running and virt.defined states.
