Commit graph

116 commits

Author SHA1 Message Date
Pedro Algarvio
0d6d4cfb36 Remove all kitchen and jenkins related resources
The salt-project hasn't been using them for a very long time.
2024-02-29 10:16:58 +00:00
Pedro Algarvio
b9be2dec1b Update and remove obsolete pylint plugins 2024-02-27 08:07:04 +00:00
Pedro Algarvio
4fbb0f9943 Fix and AttributeError on Windows
```
AttributeError: module 'signal' has no attribute 'SIGALRM'. Did you mean: 'SIGABRT'?
```
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2024-01-19 07:01:13 +00:00
Pedro Algarvio
066afb90f0 Skip tests which can't run, or even pass on FIPS enabled platforms
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2023-11-14 20:42:57 +00:00
Pedro Algarvio
3d56434d3e Upgrade to `pytest-skip-markers==1.5.0`
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2023-11-04 06:27:55 +00:00
Pedro Algarvio
4ecfd3d3d5 Use packaging for version parsing. looseversion when needed only.
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2023-01-09 12:31:51 -07:00
jeanluc
97d193db93 Revert pylint upgrade 2022-12-22 08:00:41 -07:00
jeanluc
2b1605a6b4 Suppress some new pylint warnings relevant for this PR 2022-12-22 08:00:41 -07:00
Pedro Algarvio
d0ffe3a3e1 Properly skip on non-windows platforms
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2022-12-14 11:23:26 -07:00
Pedro Algarvio
1f2c1fac9b Initial work for the Self Github Actions Runners
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2022-12-14 11:23:26 -07:00
Pedro Algarvio
29b6fe207c Updates required for `pytest-salt-factories>=1.0.0rc16`
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2022-06-02 07:05:09 -06:00
Pedro Algarvio
cedccff8c7 Migrate `tests.integration.states.test_pkgrepo` to functional tests.
Additionally, for Debian based distributions, test ``pkgrepo`` with the
system ``aptsources`` package and without it.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2022-04-11 15:02:54 -04:00
Pedro Algarvio
b5912dd349 Don't leave any gpg-agent's running behind
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
2022-03-28 08:49:54 +01:00
Pedro Algarvio
1afa3565ce No string formatting in log calls 2021-07-13 11:10:20 -04:00
Pedro Algarvio
0aba49c7d3
Bump pytest-salt-factories to 0.92.x 2020-09-14 07:55:09 +01:00
Cédric Bosdonnat
fdc77e62ca pylint: allow a few more 3rd party modules
Strangely the following errors keep blocking the pre-commit lint hook on virt
module while those never appear in the CI.

[W8410(3rd-party-module-not-gated), ] 3rd-party module import is not gated in a try/except: 'base64'
[W8410(3rd-party-module-not-gated), ] 3rd-party module import is not gated in a try/except: 'copy'
[W8410(3rd-party-module-not-gated), ] 3rd-party module import is not gated in a try/except: 'os'
[W8410(3rd-party-module-not-gated), ] 3rd-party module import is not gated in a try/except: 're'
[W8410(3rd-party-module-not-gated), ] 3rd-party module import is not gated in a try/except: 'shutil'

Add these modules to the allowed 3rd party modules to clear the errors.
2020-07-30 14:58:45 -07:00
Pedro Algarvio
cf391a2cdf Start upgrading codebase to Py3 for every changed file 2020-07-28 15:25:33 -07:00
Pedro Algarvio
fe075aaace Distro is now a hard dependency
Refs #55310
Refs #55835
2020-05-11 19:06:03 -07:00
Pedro Algarvio
e157459016 Switch to pytest-salt-factories 2020-05-07 16:00:11 -07:00
Pedro Algarvio
3dbdd90e94 Enable code refactor lint issues 2020-04-28 10:33:30 -07:00
Pedro Algarvio
3e3501f4b0
Sodium is Py3 only. Disable our Pylint Py3 compatible code checks 2020-04-14 18:56:44 +01:00
Blacken Salt
0b2a5613b3
Blacken salt 2020-04-03 13:05:41 -05:00
Wayne Werner
c1baa329c6
Add black and isort to precommit
E203 is *not* pep8 compliant, pylint.
2020-04-03 08:10:58 -05:00
Pedro Algarvio
ada6f6d96d
Switch to setuptools alone. Work around pypa/setuptools#456. 2020-01-27 23:01:17 +00:00
Pedro Algarvio
4a7b64f767
Fox now, disable PyLint keyword-arg-before-vararg 2020-01-03 12:57:48 +00:00
Pedro Algarvio
7a543cd054
For now, globaly ignore deprecated-method 2020-01-03 12:57:46 +00:00
Pedro Algarvio
594128ff75
Start ignoring import-outside-toplevel. Unfortunately we need deferred imports. 2020-01-03 08:34:58 +00:00
Pedro Algarvio
98afee1dbd
Update .pylintrc to latest default from PyLint 2020-01-03 08:34:58 +00:00
Pedro Algarvio
bf54d58600
Delete .testing.pylintrc. Use msg ids instead of msg codes. 2020-01-03 08:34:58 +00:00
Ch3LL
355551c83b
Merge remote-tracking branch 2018.3 into master
Conflicts:
  - .ci/docs
  - .ci/kitchen-amazon2-py2
  - .ci/kitchen-amazon2-py3
  - .ci/kitchen-centos6-py2
  - .ci/kitchen-centos7-py2
  - .ci/kitchen-centos7-py3
  - .ci/kitchen-debian8-py2
  - .ci/kitchen-debian9-py2
  - .ci/kitchen-debian9-py3
  - .ci/kitchen-fedora29-py2
  - .ci/kitchen-fedora29-py3
  - .ci/kitchen-ubuntu1604-py2
  - .ci/kitchen-ubuntu1604-py3
  - .ci/kitchen-ubuntu1804-py2
  - .ci/kitchen-ubuntu1804-py3
  - .ci/kitchen-windows2016-py2
  - .ci/kitchen-windows2016-py3
  - .ci/lint
  - .gitignore
  - .pre-commit-config.yaml
  - doc/man/salt-api.1
  - doc/man/salt-call.1
  - doc/man/salt-cloud.1
  - doc/man/salt-cp.1
  - doc/man/salt-key.1
  - doc/man/salt-master.1
  - doc/man/salt-minion.1
  - doc/man/salt-proxy.1
  - doc/man/salt-run.1
  - doc/man/salt-ssh.1
  - doc/man/salt-syndic.1
  - doc/man/salt-unity.1
  - doc/man/salt.1
  - doc/man/salt.7
  - doc/man/spm.1
  - doc/topics/releases/2018.3.5.rst
  - noxfile.py
  - pkg/osx/req.txt
  - pkg/windows/req.txt
  - requirements/static/amzn-2018.03.in
  - requirements/static/arch.txt
  - requirements/static/centos-6.txt
  - requirements/static/centos-7.in
  - requirements/static/centos-7.txt
  - requirements/static/cloud.in
  - requirements/static/debian-8.txt
  - requirements/static/debian-9.txt
  - requirements/static/fedora-28.txt
  - requirements/static/fedora-29.txt
  - requirements/static/fedora-30.in
  - requirements/static/lint.in
  - requirements/static/opensuse-42.txt
  - requirements/static/opensuse-leap-15.txt
  - requirements/static/osx.in
  - requirements/static/py2.7/cloud.txt
  - requirements/static/py2.7/lint.txt
  - requirements/static/py2.7/raet-arch.txt
  - requirements/static/py2.7/raet-centos-6.txt
  - requirements/static/py2.7/raet-debian-8.txt
  - requirements/static/py2.7/raet-debian-9.txt
  - requirements/static/py2.7/raet-fedora-30.txt
  - requirements/static/py2.7/raet-opensuse-42.txt
  - requirements/static/py2.7/raet-opensuse-leap-15.txt
  - requirements/static/py2.7/raet-ubuntu-16.04.txt
  - requirements/static/py2.7/raet-ubuntu-18.04.txt
  - requirements/static/py2.7/zeromq-amzn-2018.03.txt
  - requirements/static/py2.7/zeromq-arch.txt
  - requirements/static/py2.7/zeromq-centos-6.txt
  - requirements/static/py2.7/zeromq-centos-7.txt
  - requirements/static/py2.7/zeromq-debian-8.txt
  - requirements/static/py2.7/zeromq-debian-9.txt
  - requirements/static/py2.7/zeromq-fedora-29.txt
  - requirements/static/py2.7/zeromq-fedora-30.txt
  - requirements/static/py2.7/zeromq-opensuse-leap-15.txt
  - requirements/static/py2.7/zeromq-osx.txt
  - requirements/static/py2.7/zeromq-ubuntu-16.04.txt
  - requirements/static/py2.7/zeromq-ubuntu-18.04.txt
  - requirements/static/py2.7/zeromq-windows.txt
  - requirements/static/py3.4/cloud.txt
  - requirements/static/py3.4/zeromq-arch.txt
  - requirements/static/py3.4/zeromq-centos-7.txt
  - requirements/static/py3.4/zeromq-debian-8.txt
  - requirements/static/py3.4/zeromq-debian-9.txt
  - requirements/static/py3.4/zeromq-fedora-29.txt
  - requirements/static/py3.4/zeromq-fedora-30.txt
  - requirements/static/py3.4/zeromq-opensuse-leap-15.txt
  - requirements/static/py3.4/zeromq-ubuntu-16.04.txt
  - requirements/static/py3.4/zeromq-ubuntu-18.04.txt
  - requirements/static/py3.5/cloud.txt
  - requirements/static/py3.5/zeromq-arch.txt
  - requirements/static/py3.5/zeromq-centos-7.txt
  - requirements/static/py3.5/zeromq-debian-8.txt
  - requirements/static/py3.5/zeromq-debian-9.txt
  - requirements/static/py3.5/zeromq-fedora-29.txt
  - requirements/static/py3.5/zeromq-fedora-30.txt
  - requirements/static/py3.5/zeromq-opensuse-leap-15.txt
  - requirements/static/py3.5/zeromq-osx.txt
  - requirements/static/py3.5/zeromq-ubuntu-16.04.txt
  - requirements/static/py3.5/zeromq-ubuntu-18.04.txt
  - requirements/static/py3.5/zeromq-windows.txt
  - requirements/static/py3.6/cloud.txt
  - requirements/static/py3.6/zeromq-arch.txt
  - requirements/static/py3.6/zeromq-centos-7.txt
  - requirements/static/py3.6/zeromq-debian-8.txt
  - requirements/static/py3.6/zeromq-debian-9.txt
  - requirements/static/py3.6/zeromq-fedora-29.txt
  - requirements/static/py3.6/zeromq-fedora-30.txt
  - requirements/static/py3.6/zeromq-opensuse-leap-15.txt
  - requirements/static/py3.6/zeromq-osx.txt
  - requirements/static/py3.6/zeromq-ubuntu-16.04.txt
  - requirements/static/py3.6/zeromq-ubuntu-18.04.txt
  - requirements/static/py3.6/zeromq-windows.txt
  - requirements/static/py3.7/cloud.txt
  - requirements/static/py3.7/zeromq-arch.txt
  - requirements/static/py3.7/zeromq-centos-7.txt
  - requirements/static/py3.7/zeromq-debian-8.txt
  - requirements/static/py3.7/zeromq-debian-9.txt
  - requirements/static/py3.7/zeromq-fedora-29.txt
  - requirements/static/py3.7/zeromq-fedora-30.txt
  - requirements/static/py3.7/zeromq-opensuse-leap-15.txt
  - requirements/static/py3.7/zeromq-osx.txt
  - requirements/static/py3.7/zeromq-ubuntu-16.04.txt
  - requirements/static/py3.7/zeromq-ubuntu-18.04.txt
  - requirements/static/py3.7/zeromq-windows.txt
  - requirements/static/ubuntu-14.04.txt
  - requirements/static/ubuntu-16.04.txt
  - requirements/static/windows.in
  - salt/client/mixins.py
  - salt/crypt.py
  - salt/daemons/flo/core.py
  - salt/daemons/flo/worker.py
  - salt/daemons/flo/zero.py
  - salt/engines/http_logstash.py
  - salt/engines/logstash_engine.py
  - salt/modules/beacons.py
  - salt/modules/chocolatey.py
  - salt/modules/cron.py
  - salt/modules/file.py
  - salt/modules/gpg.py
  - salt/modules/http.py
  - salt/modules/state.py
  - salt/modules/win_file.py
  - salt/modules/win_task.py
  - salt/states/file.py
  - salt/states/pip_state.py
  - salt/states/saltmod.py
  - salt/transport/ipc.py
  - salt/transport/tcp.py
  - salt/transport/zeromq.py
  - salt/utils/cloud.py
  - salt/utils/napalm.py
  - salt/utils/schedule.py
  - salt/utils/vmware.py
  - salt/utils/yamlloader.py
  - tests/integration/__init__.py
  - tests/integration/client/test_kwarg.py
  - tests/integration/cloud/clouds/test_ec2.py
  - tests/integration/cloud/clouds/test_gogrid.py
  - tests/integration/cloud/clouds/test_oneandone.py
  - tests/integration/cloud/clouds/test_vmware.py
  - tests/integration/cloud/clouds/test_vultrpy.py
  - tests/integration/files/pillar/base/top.sls
  - tests/integration/modules/test_cp.py
  - tests/integration/modules/test_pip.py
  - tests/integration/modules/test_pkg.py
  - tests/integration/modules/test_state.py
  - tests/integration/modules/test_system.py
  - tests/integration/modules/test_win_lgpo.py
  - tests/integration/shell/test_call.py
  - tests/integration/states/test_beacon.py
  - tests/integration/states/test_pip_state.py
  - tests/integration/states/test_pkg.py
  - tests/support/generate-names-file-from-failed-test-reports.py
  - tests/support/gitfs.py
  - tests/support/helpers.py
  - tests/unit/modules/test_file.py
  - tests/unit/modules/test_gpg.py
  - tests/unit/modules/test_localemod.py
  - tests/unit/modules/test_win_file.py
  - tests/unit/modules/test_win_lgpo.py
  - tests/unit/states/test_file.py
  - tests/unit/states/test_pip_state.py
  - tests/unit/test_loader.py
  - tests/unit/utils/test_pycrypto.py
  - tests/unit/utils/test_schema.py
2019-10-16 10:17:36 -04:00
cmcmarrow
8cb842056e
add rule to pylintc 2019-06-07 17:30:24 +11:00
Daniel Wallace
8a341cdbb9
add docker proxy minion 2018-06-04 14:01:31 -05:00
Daniel Wallace
29806e4496
ignore salt.ext in pylint 2018-01-09 17:49:50 -07:00
rallytime
2ff02e4320
Merge branch '2016.11' into '2017.7'
No conflicts.
2017-09-29 11:39:43 -04:00
Denys Havrysh
651ed16ad3 Fix Pylint deprecated option warnings 2017-09-27 10:38:47 +03:00
rallytime
9ff2694155 Merge branch '2016.11' into 'nitrogen'
Conflicts:
  - pkg/salt-minion.service
  - salt/modules/junos.py
  - salt/modules/localemod.py
  - salt/modules/win_system.py
  - salt/states/junos.py
  - tests/unit/modules/test_localemod.py
  - tests/unit/modules/test_win_powercfg.py
  - tests/unit/states/dockerng_test.py
2017-05-24 16:32:59 -06:00
Benjamin Drung
33a7f8b2ec Fix typos
lintian found several spelling errors.

Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
2017-05-24 12:50:29 +02:00
Pedro Algarvio
0de35b51cc
Lint and syntax fixes 2017-03-09 19:29:15 +00:00
Pedro Algarvio
5e1dba88c7
The pylint-salt plugin was renamed 2017-03-09 19:29:15 +00:00
Pedro Algarvio
1e167d4042
pytest and pytestsalt should be considered good 3rd-party imports on develop 2017-03-06 14:35:16 +00:00
Pedro Algarvio
d7f05e68ee
Start linting 3rd-party imports 2017-03-06 00:51:19 +00:00
Pedro Algarvio
251c4c20ab
Add PyLint checker to make sure salttesting is not being used on develop 2017-03-01 01:33:08 +00:00
Pedro Algarvio
8a0f9fa2fe
The develop branch no longer targets python 2.6 2017-02-24 00:49:32 +00:00
Pedro Algarvio
49da135abd
Don't use our own six dictionary fixes in this branch 2017-02-22 17:18:55 +00:00
Pedro Algarvio
1dd7d8d88f
Require SaltPyLint >= v2017.2.22
Minimal Python version for develop is now 2.7
2017-02-22 12:15:31 +00:00
Thomas S Hatch
c7575c992e update lint with new thorium builtins 2016-02-03 18:34:17 -07:00
Thomas S Hatch
aff4dca278 update lint with new thorium builtins 2016-02-02 17:51:28 -07:00
Mike Place
7e540e2c35 Adding new dunders to pylintrcs
Make __serializers__ known to pylint. Refs #28926 and #28906
2015-11-18 11:39:23 -07:00
C. R. Oldham
72032650b8 Add __proxy__ to the list of builtins. 2015-10-12 08:34:36 -06:00
Pedro Algarvio
171e022331 Start checking code to enforce a minimum python version support 2015-05-04 15:25:38 +01:00