Also remove a bunch of needless calls to "keys", as membership checks
for dicts are more efficient using the built-in dict membership check,
which utilizes hashing instead of iterating over the keys.
Otherwise a race can happen between Salt processes and results in unpack error:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/pillar/__init__.py", line 745, in render_pstate
**defaults)
File "/usr/lib/python3/dist-packages/salt/template.py", line 101, in compile_template
ret = render(input_data, saltenv, sls, **render_kwargs)
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 378, in render
return _decrypt_object(gpg_data, translate_newlines=translate_newlines, encoding=kwargs.get('encoding', None))
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 357, in _decrypt_object
translate_newlines=translate_newlines)
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 353, in _decrypt_object
return _decrypt_ciphertexts(obj, translate_newlines=translate_newlines, encoding=encoding)
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 328, in _decrypt_ciphertexts
ret, num = GPG_CIPHERTEXT.subn(replace, to_bytes(cipher))
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 325, in replace
result = to_bytes(_decrypt_ciphertext(match.group()))
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 298, in _decrypt_ciphertext
cache = _get_cache()
File "/usr/lib/python3/dist-packages/salt/renderers/gpg.py", line 280, in _get_cache
minion_cache_path=os.path.join(cachedir, 'gpg_cache')
File "/usr/lib/python3/dist-packages/salt/utils/cache.py", line 37, in factory
return CacheDisk(ttl, kwargs['minion_cache_path'], *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/utils/cache.py", line 90, in __init__
self._read()
File "/usr/lib/python3/dist-packages/salt/utils/cache.py", line 138, in _read
cache = salt.utils.data.decode(salt.utils.msgpack.load(fp_, encoding=__salt_system_encoding__))
File "/usr/lib/python3/dist-packages/salt/utils/msgpack.py", line 116, in unpack
return msgpack.unpack(stream, **_sanitize_msgpack_kwargs(kwargs))
File "/usr/lib/python3/dist-packages/msgpack/__init__.py", line 58, in unpack
return unpackb(data, **kwargs)
File "msgpack/_unpacker.pyx", line 211, in msgpack._unpacker.unpackb
msgpack.exceptions.UnpackValueError: Unpack failed: error = 0
* Drop deprecated mac_brew_pkg namespace fixup
Closes#57361
* Note deprecation in release notes
* Remove deprecated napalm_network features
Closes#57362
These arguments are no longer useful, since we no longer support using
NAPALM native templates.
* Remove selinux.fcontext_add_or_delete_policy
It was deprecated and slated for removal in Sodium. Closes#57363
* Remove deprecated refresh_db param
Closes#57366
Parameter has been renamed to `refresh`
* Remove deprecated sdecode functions
Closes#57367
sdecode and sdecode_if_string functionalities have both been moved to
decode.
* Remove assorted deprecated features
Closes#57368
- removed obsolete .destroy methods from zeromq channels
- removed winexe support from salt.utils.cloud
- removed obsolete override_name from
salt.utils.context.NamespacedDictWrapper
- removed obsolete `show_ipv4` parameter from salt.utils.minions
- removed impacket support from salt.utils.smb
- removed obsolete salt.transport.Channel, and fixed test.
* Change module.run deprecation version
* Remove deprecated destroy test
* Remove deprecation from skip
* Re-add keystone docs
* Blacken merge conflict
Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com>
Some libvirt storage pools backends don't implement the build function.
In thoses cases the virt.pool_defined and virt.pool_running states must
not run the virt.pool_build() function.
There are also cases where build only works once. For example when
creating a LVM VG or a disk partition pool, if the VG or partition is
already present build will fail.
Fixes issue #56454
In #20602 we added the ability to change ARPCHECK in network settings.
This was missing and later added in RH7, but was missing from RH8, since
RH8 support was added before we updated the RH7 support.
This fixes#57047
In order to support creating VMs with disk on more storage pools like
iSCSI, disks, LVM, RBD, etc, virt.init needs to handle disks not only as
files, but also as libvirt volumes.
In order to get all possible capabilities from a host, the user has to
call virt.capabilities, and then loop over the guests and domains
before calling virt.domain_capabilities for each of them.
This commit embeds all this logic to get them all in a single
virt.all_capabilities call.
