From f77d7ea7502232dffb8214d893a0a08ad546d480 Mon Sep 17 00:00:00 2001 From: Erik Johnson Date: Mon, 12 Feb 2024 20:44:37 -0600 Subject: [PATCH] Updates to contributing docs 1. Docs reference an EOL version of Python when recommending a version to install using pyenv. (resolves #65978) 2. Fixes incorrect location for tests (as described in #66021) --- CONTRIBUTING.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index ee4ab88e193..6a41d924ae3 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -88,7 +88,7 @@ version of Python: :: - pyenv install 3.7.0 + pyenv install 3.9.18 If that fails, don't panic! You're probably just missing some build dependencies. Check out `pyenv common build @@ -99,7 +99,7 @@ new virtual environment with this command: :: - pyenv virtualenv 3.7.0 salt + pyenv virtualenv 3.9.18 salt Then activate it: @@ -321,8 +321,8 @@ documentation: :: - pyenv install 3.7.15 - pyenv virtualenv 3.7.15 salt-docs + pyenv install 3.9.18 + pyenv virtualenv 3.9.18 salt-docs echo 'salt-docs' > .python-version #. Activate `pyenv` if it's not auto-activated: @@ -477,7 +477,7 @@ meaningful and complete! *Typically* the best tests for Salt are going to be unit tests. Testing is `a whole topic on its own `__, But you may also want to write functional or integration tests. You'll -find those in the ``salt/tests`` directory. +find those in the ``tests/`` directory. When you're thinking about tests to write, the most important thing to keep in mind is, “What, exactly, am I testing?” When a test fails, you