From 0893fcacbab74c298b40ecd3bca0b0932e246994 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 16 Apr 2020 15:28:26 +0100 Subject: [PATCH 1/2] Last bit to disable codecov's PR status checks --- .codecov.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.codecov.yml b/.codecov.yml index 8272b0f37c1..ca1cffb1fa4 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -7,9 +7,8 @@ codecov: # require_ci_to_pass: yes # Less spammy. Only notify on passing builds. - notify: off # Disable Notifications # notify: -# after_n_builds: 46 # Only notify after N builds +# after_n_builds: 25 # Only notify after N builds # # This value is the output of: # # sh -c 'echo "$(ls .ci/ | grep kitchen | wc -l)"' # wait_for_ci: yes # Should Codecov wait for all CI statuses to complete before sending ours. @@ -28,7 +27,8 @@ coverage: status: project: # measuring the overall project coverage - default: false # disable the default status that measures entire project + default: + enabled: no # disable the default status that measures entire project salt: # declare a new status context "salt" enabled: no # must be yes|true to enable this status paths: "!tests/" # remove all files in "tests/" From 9bf1e848406dee49a6c54c143e1e926de03d29a8 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 16 Apr 2020 16:07:55 +0100 Subject: [PATCH 2/2] Let's still have information, but not block the PR merge --- .codecov.yml | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/.codecov.yml b/.codecov.yml index ca1cffb1fa4..d7157478d1b 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -28,9 +28,12 @@ coverage: status: project: # measuring the overall project coverage default: - enabled: no # disable the default status that measures entire project + informational: true # Use Codecov in informational mode. Default is false. If true is specified the + # resulting status will pass no matter what the coverage is or what other settings + # are specified. Informational mode is great to use if you want to expose codecov + # information to other developers in your pull request without necessarily gating + # PRs on that information. salt: # declare a new status context "salt" - enabled: no # must be yes|true to enable this status paths: "!tests/" # remove all files in "tests/" target: auto # will use the coverage from the base commit (pull request base or parent commit) coverage to compare against. base: auto # will use the pull request base if the commit is on a pull request. If not, the parent commit will be used. @@ -39,7 +42,6 @@ coverage: if_not_found: success # if parent is not found report status as success, error, or failure if_ci_failed: error # if ci fails report status as success, error, or failure tests: # declare a new status context "tests" - enabled: no # must be yes|true to enable this status #target: 100% # we always want 100% coverage here target: auto # auto while we get this going base: auto # will use the pull request base if the commit is on a pull request. If not, the parent commit will be used. @@ -53,7 +55,11 @@ coverage: # entire pull requests Coverage Diff. Checking if the lines # adjusted are covered at least X%. default: - enabled: no # must be yes|true to enable this status + informational: true # Use Codecov in informational mode. Default is false. If true is specified the + # resulting status will pass no matter what the coverage is or what other settings + # are specified. Informational mode is great to use if you want to expose codecov + # information to other developers in your pull request without necessarily gating + # PRs on that information. target: 100% # Newly added lines must have 100% coverage if_no_uploads: error # will post commit status of "error" if no coverage reports were uploaded # options: success, error, failure @@ -62,7 +68,11 @@ coverage: changes: # if there are any unexpected changes in coverage default: - enabled: no # must be yes|true to enable this status + informational: true # Use Codecov in informational mode. Default is false. If true is specified the + # resulting status will pass no matter what the coverage is or what other settings + # are specified. Informational mode is great to use if you want to expose codecov + # information to other developers in your pull request without necessarily gating + # PRs on that information. if_no_uploads: error if_not_found: success if_ci_failed: error