saltstack/salt
1
0
Fork 0
mirror of https://github.com/saltstack/salt.git synced 2025-04-17 10:10:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

suggested changes

Browse source
This commit is contained in:
Gareth J. Greenaway 2023-11-20 09:46:47 -08:00 • committed by Daniel Wozniak
parent b5b1ee0ff1
commit ef46b8452c
1 changed files with 55 additions and 103 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

158
tests/pytests/functional/modules/test_mac_brew_pkg.py
View file

@ -5,8 +5,6 @@
import pytest
from salt.exceptions import CommandExecutionError
pytestmark = [
pytest.mark.slow_test,
pytest.mark.destructive_test,
@ -34,8 +32,8 @@ def del_pkg():
yield "acme"
@pytest.fixture(scope="function")
def setup_teardown_vars(pkg, add_pkg, del_pkg):
@pytest.fixture(scope="function", autouse=True)
def _setup_teardown_vars(pkg, add_pkg, del_pkg):
try:
yield
finally:
@ -48,77 +46,55 @@ def setup_teardown_vars(pkg, add_pkg, del_pkg):
pkg.remove(del_pkg)
def test_brew_install(pkg, add_pkg, setup_teardown_vars):
def test_brew_install(pkg, add_pkg):
"""
Tests the installation of packages
"""
try:
pkg.install(add_pkg)
pkg_list = pkg.list_pkgs()
try:
assert add_pkg in pkg_list
except AssertionError:
pkg.remove(add_pkg)
raise
except CommandExecutionError:
pkg.remove(add_pkg)
raise
pkg.install(add_pkg)
pkg_list = pkg.list_pkgs()
assert add_pkg in pkg_list
def test_remove(pkg, del_pkg, setup_teardown_vars):
def test_remove(pkg, del_pkg):
"""
Tests the removal of packages
"""
try:
# Install a package to delete - If unsuccessful, skip the test
# Install a package to delete - If unsuccessful, skip the test
pkg.install(del_pkg)
pkg_list = pkg.list_pkgs()
if del_pkg not in pkg_list:
pkg.install(del_pkg)
pkg_list = pkg.list_pkgs()
if del_pkg not in pkg_list:
pkg.install(del_pkg)
pytest.skip("Failed to install a package to delete")
pytest.skip("Failed to install a package to delete")
# Now remove the installed package
pkg.remove(del_pkg)
del_list = pkg.list_pkgs()
assert del_pkg not in del_list
except CommandExecutionError:
pkg.remove(del_pkg)
raise
# Now remove the installed package
pkg.remove(del_pkg)
del_list = pkg.list_pkgs()
assert del_pkg not in del_list
def test_version(pkg, add_pkg, setup_teardown_vars):
def test_version(pkg, add_pkg):
"""
Test pkg.version for mac. Installs a package and then checks we can get
a version for the installed package.
"""
try:
pkg.install(add_pkg)
pkg_list = pkg.list_pkgs()
version = pkg.version(add_pkg)
try:
assert version, "version: {} is empty, or other issue is present".format(
version
)
assert (
add_pkg in pkg_list
), "package: {} is not in the list of installed packages: {}".format(
add_pkg, pkg_list
)
# make sure the version is accurate and is listed in the pkg_list
assert version in str(
pkg_list[add_pkg]
), "The {} version: {} is not listed in the pkg_list: {}".format(
add_pkg, version, pkg_list[add_pkg]
)
except AssertionError:
pkg.remove(add_pkg)
raise
except CommandExecutionError:
pkg.remove(add_pkg)
raise
pkg.install(add_pkg)
pkg_list = pkg.list_pkgs()
version = pkg.version(add_pkg)
assert version, f"version: {version} is empty, or other issue is present"
assert (
add_pkg in pkg_list
), "package: {} is not in the list of installed packages: {}".format(
add_pkg, pkg_list
)
# make sure the version is accurate and is listed in the pkg_list
assert version in str(
pkg_list[add_pkg]
), "The {} version: {} is not listed in the pkg_list: {}".format(
add_pkg, version, pkg_list[add_pkg]
)
def test_latest_version(pkg, add_pkg, setup_teardown_vars):
def test_latest_version(pkg, add_pkg):
"""
Test pkg.latest_version:
- get the latest version available
@ -126,25 +102,17 @@ def test_latest_version(pkg, add_pkg, setup_teardown_vars):
- get the latest version available
- check that the latest version is empty after installing it
"""
try:
pkg.remove(add_pkg)
uninstalled_latest = pkg.latest_version(add_pkg)
pkg.remove(add_pkg)
uninstalled_latest = pkg.latest_version(add_pkg)
pkg.install(add_pkg)
installed_latest = pkg.latest_version(add_pkg)
version = pkg.version(add_pkg)
try:
assert isinstance(uninstalled_latest, str)
assert installed_latest == version
except AssertionError:
pkg.remove(add_pkg)
raise
except CommandExecutionError:
pkg.remove(add_pkg)
raise
pkg.install(add_pkg)
installed_latest = pkg.latest_version(add_pkg)
version = pkg.version(add_pkg)
assert isinstance(uninstalled_latest, str)
assert installed_latest == version
def test_refresh_db(pkg, setup_teardown_vars):
def test_refresh_db(pkg):
"""
Integration test to ensure pkg.refresh_db works with brew
"""
@ -152,43 +120,27 @@ def test_refresh_db(pkg, setup_teardown_vars):
assert refresh_brew
def test_list_upgrades(pkg, add_pkg, setup_teardown_vars):
def test_list_upgrades(pkg, add_pkg):
"""
Test pkg.list_upgrades: data is in the form {'name1': 'version1',
'name2': 'version2', ... }
"""
try:
upgrades = pkg.list_upgrades()
try:
assert isinstance(upgrades, dict)
if upgrades:
for name in upgrades:
assert isinstance(name, str)
assert isinstance(upgrades[name], str)
except AssertionError:
pkg.remove(add_pkg)
raise
except CommandExecutionError:
pkg.remove(add_pkg)
raise
upgrades = pkg.list_upgrades()
assert isinstance(upgrades, dict)
if upgrades:
for name in upgrades:
assert isinstance(name, str)
assert isinstance(upgrades[name], str)
def test_info_installed(pkg, add_pkg, setup_teardown_vars):
def test_info_installed(pkg, add_pkg):
"""
Test pkg.info_installed: info returned has certain fields used by
mac_brew.latest_version
"""
try:
pkg.install(add_pkg)
info = pkg.info_installed(add_pkg)
try:
assert add_pkg in info
assert "versions" in info[add_pkg]
assert "revision" in info[add_pkg]
assert "stable" in info[add_pkg]["versions"]
except AssertionError:
pkg.remove(add_pkg)
raise
except CommandExecutionError:
pkg.remove(add_pkg)
raise
pkg.install(add_pkg)
info = pkg.info_installed(add_pkg)
assert add_pkg in info
assert "versions" in info[add_pkg]
assert "revision" in info[add_pkg]
assert "stable" in info[add_pkg]["versions"]