diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index ef82f9f884f..7494866c5cd 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -2123,13 +2123,13 @@ jobs: with: payload: | { - "text": "Nightly Workflow build result for the ${{ github.ref_name }} branch: ${{ steps.get-workflow-info.outputs.conclusion }}\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}", + "text": "Nightly Workflow build result for the `${{ github.ref_name }}` branch(attempt: ${{ github.run_attempt }}): `${{ steps.get-workflow-info.outputs.conclusion }}`\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": "Nightly Workflow build result for the ${{ github.ref_name }} branch: ${{ steps.get-workflow-info.outputs.conclusion }}\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" + "text": "Nightly Workflow build result for the `${{ github.ref_name }}` branch(attempt: ${{ github.run_attempt }})\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" } } ] diff --git a/.github/workflows/templates/nightly.yml.jinja b/.github/workflows/templates/nightly.yml.jinja index 0aa970a27ae..391ffc6170a 100644 --- a/.github/workflows/templates/nightly.yml.jinja +++ b/.github/workflows/templates/nightly.yml.jinja @@ -127,13 +127,13 @@ concurrency: with: payload: | { - "text": "Nightly Workflow build result for the ${{ github.ref_name }} branch: ${{ steps.get-workflow-info.outputs.conclusion }}\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}", + "text": "Nightly Workflow build result for the `${{ github.ref_name }}` branch(attempt: ${{ github.run_attempt }}): `${{ steps.get-workflow-info.outputs.conclusion }}`\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": "Nightly Workflow build result for the ${{ github.ref_name }} branch: ${{ steps.get-workflow-info.outputs.conclusion }}\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" + "text": "Nightly Workflow build result for the `${{ github.ref_name }}` branch(attempt: ${{ github.run_attempt }})\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" } } ] diff --git a/pkg/tests/conftest.py b/pkg/tests/conftest.py index 89f54fe2f72..293a43603e9 100644 --- a/pkg/tests/conftest.py +++ b/pkg/tests/conftest.py @@ -44,6 +44,21 @@ def grains(sminion): return sminion.opts["grains"].copy() +@pytest.fixture(scope="module", autouse=True) +def _system_up_to_date( + grains, + shell, +): + if grains["os_family"] == "Debian": + ret = shell.run("apt", "update") + assert ret.returncode == 0 + ret = shell.run("apt", "upgrade", "-y") + assert ret.returncode == 0 + elif grains["os_family"] == "Redhat": + ret = shell.run("yum", "update", "-y") + assert ret.returncode == 0 + + def pytest_addoption(parser): """ register argparse-style options and ini-style config values. diff --git a/pkg/tests/upgrade/test_salt_upgrade.py b/pkg/tests/upgrade/test_salt_upgrade.py index 3aa50b0ecd7..0514eb619c0 100644 --- a/pkg/tests/upgrade/test_salt_upgrade.py +++ b/pkg/tests/upgrade/test_salt_upgrade.py @@ -19,6 +19,7 @@ def test_salt_upgrade(salt_call_cli, salt_minion, install_salt): assert install.returncode == 0 use_lib = salt_call_cli.run("--local", "github.get_repo_info", repo) assert "Authentication information could" in use_lib.stderr + # upgrade Salt from previous version and test install_salt.install(upgrade=True) ret = salt_call_cli.run("test.ping")