saltstack/salt
1
0
Fork 0
mirror of https://github.com/saltstack/salt.git synced 2025-04-17 10:10:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Refactor to prevent logical bug when gid is 0

Browse source
This commit is contained in:
Pablo Suárez Hernández 2018-01-16 15:18:10 +00:00
parent 9fdaa0d5e9
commit da23067f80
No known key found for this signature in database
GPG key ID: A9683F02B512C911
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
salt/states/user.py
View file

@ -88,10 +88,6 @@ def _changes(name,
attributes supported as integers only.
'''
# Set gid to None in cases an empty string is passed
if gid == '':
gid = None
if 'shadow.info' in __salt__:
lshad = __salt__['shadow.info'](name)
@ -460,9 +456,8 @@ def present(name,
if gid_from_name:
gid = __salt__['file.group_to_gid'](name)
if not gid:
ret['comment'] = 'Default group with name "{0}" ' \
'is not present'.format(name)
if gid == '':
ret['comment'] = 'Default group with name "{0}" is not present'.format(name)
ret['result'] = False
return ret