saltstack/salt
1
0
Fork 0
mirror of https://github.com/saltstack/salt.git synced 2025-04-17 10:10:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(pkgrepo): fix regression with refresh_db warning for Neon

Browse source 
* Regression detected during weekly test of Salt's `master` branch using
  the Formula's CI
  - Both instances now failing:
    https://travis-ci.org/github/myii/apt-formula/builds/681357766
  - Specific error:
    https://travis-ci.org/github/myii/apt-formula/jobs/681357767#L1517-L1530
* Regression introduced recently during port of #53537 to `master`:
  - https://github.com/saltstack/salt/blame/master/salt/states/pkgrepo.py#L313-L318
* Propose modification `Neon` => `Sodium` since there's been no warning
  given in the state prior to this (checked via. the blame)
* Confirmed this fixes the regression:
  - Both instances now passing:
    https://travis-ci.org/github/myii/apt-formula/builds/682550353
  - Specific warning message for `Sodium` visible:
    https://travis-ci.org/github/myii/apt-formula/jobs/682550354#L1394
This commit is contained in:
Imran Iqbal 2020-05-03 11:10:03 +01:00 • committed by Daniel Wozniak
parent 2b65a5fb44
commit d8b51d2158
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
salt/states/pkgrepo.py
View file

@ -311,10 +311,10 @@ def managed(name, ppa=None, **kwargs):
"""
if "refresh_db" in kwargs:
salt.utils.versions.warn_until(
"Neon",
"Sodium",
"The 'refresh_db' argument to 'pkg.mod_repo' has been "
"renamed to 'refresh'. Support for using 'refresh_db' will be "
"removed in the Neon release of Salt.",
"removed in the Sodium release of Salt.",
)
kwargs["refresh"] = kwargs.pop("refresh_db")