Merge pull request #47193 from Ch3LL/network_test

Add network module integration tests

tests/integration/modules/test_network.py

@@ -0,0 +1,58 @@
+# -*- coding: utf-8 -*-
+
+# Import Python libs
+from __future__ import absolute_import
+
+# Import Salt Testing libs
+from tests.support.case import ModuleCase
+from tests.support.unit import skipIf
+
+# Import Salt Libs
+import salt.utils
+
+URL = 'repo.saltstack.com'
+
+
+class NetworkTest(ModuleCase):
+    '''
+    Validate network module
+    '''
+    def test_network_ping(self):
+        '''
+        network.ping
+        '''
+        ret = self.run_function('network.ping', [URL])
+        exp_out = ['ping', URL, 'ttl', 'time']
+        for out in exp_out:
+            self.assertIn(out, ret.lower())
+
+    def test_network_netstat(self):
+        '''
+        network.netstat
+        '''
+        ret = self.run_function('network.netstat')
+        exp_out = ['proto', 'local-address']
+        for val in ret:
+            for out in exp_out:
+                self.assertIn(out, val)
+
+    def test_network_traceroute(self):
+        '''
+        network.traceroute
+        '''
+        if not salt.utils.which('traceroute') and not salt.utils.is_windows():
+            self.skipTest('traceroute not installed')
+        ret = self.run_function('network.traceroute', [URL])
+        exp_out = ['hostname', 'ip']
+        for out in exp_out:
+            self.assertIn(out, exp_out)
+
+    @skipIf(not salt.utils.is_windows(), 'windows only test')
+    def test_network_nslookup(self):
+        '''
+        network.nslookup
+        '''
+        ret = self.run_function('network.nslookup', [URL])
+        exp_out = ['Server', 'Address']
+        for out in exp_out:
+            self.assertIn(out, exp_out)

tests/whitelist.txt

@@ -15,6 +15,7 @@ integration.modules.test_grains
 integration.modules.test_groupadd
 integration.modules.test_hosts
 integration.modules.test_mine
+integration.modules.test_network
 integration.modules.test_pillar
 integration.modules.test_pkg
 integration.modules.test_publish