From c2a6550bc1d5d8756b22ebf0d155c6f28bece6d0 Mon Sep 17 00:00:00 2001 From: hurzhurz Date: Fri, 26 Apr 2024 09:48:47 +0200 Subject: [PATCH] fix wintask.info: ExecutionTimeLimit and unknown values ExecutionTimeLimit: can be nothing or "PT0S" if not used _reverse_lookup: if not found, return "invalid value" instead of the last dict element --- salt/modules/win_task.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/salt/modules/win_task.py b/salt/modules/win_task.py index 2b23e381bc0..78a5201e9f8 100644 --- a/salt/modules/win_task.py +++ b/salt/modules/win_task.py @@ -253,6 +253,8 @@ def _reverse_lookup(dictionary, value): value_index = idx break + if value_index < 0: + return "invalid value" return list(dictionary)[value_index] @@ -1494,7 +1496,7 @@ def info(name, location="\\"): duration, def_set.DeleteExpiredTaskAfter ) - if def_set.ExecutionTimeLimit == "": + if def_set.ExecutionTimeLimit == "" or def_set.ExecutionTimeLimit == "PT0S": settings["execution_time_limit"] = False else: settings["execution_time_limit"] = _reverse_lookup(