From b6dcf7ec186576986404556798b1b6635eb40619 Mon Sep 17 00:00:00 2001 From: nicholasmhughes Date: Mon, 13 Nov 2023 09:20:41 -0500 Subject: [PATCH] fixes saltstack/salt#65295 nftables module type does not ensure unique nft family values (cherry picked from commit ab72e70697cac3cf2e8876ce36425a0ba7f53e03) --- changelog/65295.fixed.md | 1 + salt/modules/nftables.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelog/65295.fixed.md diff --git a/changelog/65295.fixed.md b/changelog/65295.fixed.md new file mode 100644 index 00000000000..c672de05b75 --- /dev/null +++ b/changelog/65295.fixed.md @@ -0,0 +1 @@ +Fix typo in nftables module to ensure unique nft family values diff --git a/salt/modules/nftables.py b/salt/modules/nftables.py index 29479d10ddc..4c9f1aad44a 100644 --- a/salt/modules/nftables.py +++ b/salt/modules/nftables.py @@ -446,9 +446,9 @@ def save(filename=None, family="ipv4"): if _conf() and not filename: filename = _conf() - # Not a typo. Invert the dictionary twice to get unique values only. - nft_families = {v: k for k, v in _NFTABLES_FAMILIES.items()} + # Invert the dictionary twice to get unique values only. nft_families = {v: k for k, v in _NFTABLES_FAMILIES.items()} + nft_families = {v: k for k, v in nft_families.items()} rules = "#! nft -f\n"