saltstack/salt
1
0
Fork 0
mirror of https://github.com/saltstack/salt.git synced 2025-04-16 09:40:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add tests for boto route53 VPCs

Browse source 
These tests exhibit the buggy behavior in certain boto versions.
This commit is contained in:
Wayne Werner 2021-05-25 15:24:09 -05:00 • committed by Megan Wilhite
parent 01899bec0c
commit 7b23327bf8
1 changed files with 56 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

57
tests/pytests/unit/states/test_boto_route53.py
View file

@ -3,8 +3,10 @@
"""
import pytest
import salt.modules.boto_route53 as boto53mod
import salt.modules.boto_vpc as botovpcmod
import salt.states.boto_route53 as boto_route53
from tests.support.mock import MagicMock, patch
from tests.support.mock import MagicMock, create_autospec, patch
@pytest.fixture
@ -12,6 +14,45 @@ def configure_loader_modules():
return {boto_route53: {}}
@pytest.fixture
def patch_botomod_hosted_zones():
with patch.dict(
boto_route53.__salt__,
{
"boto_route53.describe_hosted_zones": create_autospec(
boto53mod.describe_hosted_zones
),
"boto_vpc.describe_vpcs": create_autospec(botovpcmod.describe_vpcs),
},
):
yield
@pytest.fixture
def fake_single_vpc(patch_botomod_hosted_zones):
boto_route53.__salt__["boto_vpc.describe_vpcs"].return_value = {
"vpcs": [{"region": "fnordland", "id": "fnord"}],
}
boto_route53.__salt__["boto_route53.describe_hosted_zones"].return_value = {
"HostedZone": {"Config": {"PrivateZone": "true"}},
"VPCs": {"VPC": {"VPCId": "fnord", "VPCRegion": "fnordland"}},
}
@pytest.fixture
def fake_multiple_vpcs(patch_botomod_hosted_zones):
boto_route53.__salt__["boto_vpc.describe_vpcs"].return_value = {
"vpcs": [{"region": "fnordland", "id": "fnord"}],
}
boto_route53.__salt__["boto_route53.describe_hosted_zones"].return_value = {
"HostedZone": {"Config": {"PrivateZone": "true"}},
"VPCs": [
{"VPCId": "fnord", "VPCRegion": "fnordland"},
{"VPCId": "fnord part 2", "VPCRegion": "fnordlandia"},
],
}
def test_present():
"""
Test to ensure the Route53 record is present.
@ -67,3 +108,17 @@ def test_absent():
comt = "Route53 record {} set to be deleted.".format(name)
ret.update({"comment": comt, "result": None})
assert boto_route53.absent(name, zone, record_type) == ret
def test_hosted_zone_present_should_not_fail_when_one_vpc_in_deets(fake_single_vpc):
boto_route53.hosted_zone_present(
name="fnord", private_zone=True, vpc_region="fnordland", vpc_name="fnord"
)
def test_hosted_zone_present_should_not_fail_with_multiple_vpcs_in_deets(
fake_multiple_vpcs,
):
boto_route53.hosted_zone_present(
name="fnord", private_zone=True, vpc_region="fnordland", vpc_name="fnord"
)