migrate test_linux_service to pytest

tests/pytests/unit/modules/test_linux_service.py

@@ -0,0 +1,101 @@
+"""
+    :codeauthor: Jayesh Kariya <jayeshk@saltstack.com>
+
+    Test cases for salt.modules.linux_service
+"""
+
+import os
+
+import pytest
+
+import salt.modules.linux_service as service
+from tests.support.mock import MagicMock, patch
+
+
+@pytest.fixture
+def configure_loader_modules():
+    return {service: {}}
+
+
+def test_start():
+    """
+    Test to start the specified service
+    """
+    with patch.object(os.path, "join", return_value="A"):
+        with patch.object(service, "run", MagicMock(return_value=True)):
+            assert service.start("name")
+
+
+def test_stop():
+    """
+    Test to stop the specified service
+    """
+    with patch.object(os.path, "join", return_value="A"):
+        with patch.object(service, "run", MagicMock(return_value=True)):
+            assert service.stop("name")
+
+
+def test_restart():
+    """
+    Test to restart the specified service
+    """
+    with patch.object(os.path, "join", return_value="A"):
+        with patch.object(service, "run", MagicMock(return_value=True)):
+            assert service.restart("name")
+
+
+def test_status():
+    """
+    Test to return the status for a service, returns the PID or an empty
+    string if the service is running or not, pass a signature to use to
+    find the service via ps
+    """
+    with patch.dict(service.__salt__, {"status.pid": MagicMock(return_value=True)}):
+        assert service.status("name")
+
+
+def test_reload_():
+    """
+    Test to restart the specified service
+    """
+    with patch.object(os.path, "join", return_value="A"):
+        with patch.object(service, "run", MagicMock(return_value=True)):
+            assert service.reload_("name")
+
+
+def test_run():
+    """
+    Test to run the specified service
+    """
+    with patch.object(os.path, "join", return_value="A"):
+        with patch.object(service, "run", MagicMock(return_value=True)):
+            assert service.run("name", "action")
+
+
+def test_available():
+    """
+    Test to returns ``True`` if the specified service is available,
+    otherwise returns ``False``.
+    """
+    with patch.object(service, "get_all", return_value=["name", "A"]):
+        assert service.available("name")
+
+
+def test_missing():
+    """
+    Test to inverse of service.available.
+    """
+    with patch.object(service, "get_all", return_value=["name1", "A"]):
+        assert service.missing("name")
+
+
+def test_get_all():
+    """
+    Test to return a list of all available services
+    """
+    with patch.object(os.path, "isdir", side_effect=[False, True]):
+
+        assert service.get_all() == []
+
+        with patch.object(os, "listdir", return_value=["A", "B"]):
+            assert service.get_all() == ["A", "B"]

tests/unit/modules/test_linux_service.py

@@ -1,94 +0,0 @@
-"""
-    :codeauthor: Jayesh Kariya <jayeshk@saltstack.com>
-"""
-
-import os
-
-import salt.modules.linux_service as service
-from tests.support.mixins import LoaderModuleMockMixin
-from tests.support.mock import MagicMock, patch
-from tests.support.unit import TestCase
-
-
-class ServiceTestCase(TestCase, LoaderModuleMockMixin):
-    """
-    Test cases for salt.modules.linux_service
-    """
-
-    def setup_loader_modules(self):
-        return {service: {}}
-
-    def test_start(self):
-        """
-        Test to start the specified service
-        """
-        with patch.object(os.path, "join", return_value="A"):
-            with patch.object(service, "run", MagicMock(return_value=True)):
-                self.assertTrue(service.start("name"))
-
-    def test_stop(self):
-        """
-        Test to stop the specified service
-        """
-        with patch.object(os.path, "join", return_value="A"):
-            with patch.object(service, "run", MagicMock(return_value=True)):
-                self.assertTrue(service.stop("name"))
-
-    def test_restart(self):
-        """
-        Test to restart the specified service
-        """
-        with patch.object(os.path, "join", return_value="A"):
-            with patch.object(service, "run", MagicMock(return_value=True)):
-                self.assertTrue(service.restart("name"))
-
-    def test_status(self):
-        """
-        Test to return the status for a service, returns the PID or an empty
-        string if the service is running or not, pass a signature to use to
-        find the service via ps
-        """
-        with patch.dict(service.__salt__, {"status.pid": MagicMock(return_value=True)}):
-            self.assertTrue(service.status("name"))
-
-    def test_reload_(self):
-        """
-        Test to restart the specified service
-        """
-        with patch.object(os.path, "join", return_value="A"):
-            with patch.object(service, "run", MagicMock(return_value=True)):
-                self.assertTrue(service.reload_("name"))
-
-    def test_run(self):
-        """
-        Test to run the specified service
-        """
-        with patch.object(os.path, "join", return_value="A"):
-            with patch.object(service, "run", MagicMock(return_value=True)):
-                self.assertTrue(service.run("name", "action"))
-
-    def test_available(self):
-        """
-        Test to returns ``True`` if the specified service is available,
-        otherwise returns ``False``.
-        """
-        with patch.object(service, "get_all", return_value=["name", "A"]):
-            self.assertTrue(service.available("name"))
-
-    def test_missing(self):
-        """
-        Test to inverse of service.available.
-        """
-        with patch.object(service, "get_all", return_value=["name1", "A"]):
-            self.assertTrue(service.missing("name"))
-
-    def test_get_all(self):
-        """
-        Test to return a list of all available services
-        """
-        with patch.object(os.path, "isdir", side_effect=[False, True]):
-
-            self.assertEqual(service.get_all(), [])
-
-            with patch.object(os, "listdir", return_value=["A", "B"]):
-                self.assertListEqual(service.get_all(), ["A", "B"])