mirror of
https://github.com/saltstack/salt.git
synced 2025-04-17 10:10:20 +00:00
migrate test_dnsmasq to pytest
This commit is contained in:
Frode Gundersen
Megan Wilhite
parent
c6d52aedfe
commit
46be5cf020
2 changed files with 109 additions and 106 deletions
109
tests/pytests/unit/modules/test_dnsmasq.py
Normal file
109
tests/pytests/unit/modules/test_dnsmasq.py
Normal file
|
|
@ -0,0 +1,109 @@
|
|||
"""
|
||||
:codeauthor: Rupesh Tare <rupesht@saltstack.com>
|
||||
"""
|
||||
|
||||
import os
|
||||
import textwrap
|
||||
|
||||
import pytest
|
||||
|
||||
import salt.modules.dnsmasq as dnsmasq
|
||||
from salt.exceptions import CommandExecutionError
|
||||
from tests.support.mock import MagicMock, mock_open, patch
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def configure_loader_modules():
|
||||
return {dnsmasq: {}}
|
||||
|
||||
|
||||
def test_version():
|
||||
"""
|
||||
test to show installed version of dnsmasq.
|
||||
"""
|
||||
mock = MagicMock(return_value="A B C")
|
||||
with patch.dict(dnsmasq.__salt__, {"cmd.run": mock}):
|
||||
assert dnsmasq.version() == "C"
|
||||
|
||||
|
||||
def test_fullversion():
|
||||
"""
|
||||
Test to Show installed version of dnsmasq and compile options.
|
||||
"""
|
||||
mock = MagicMock(return_value="A B C\nD E F G H I")
|
||||
with patch.dict(dnsmasq.__salt__, {"cmd.run": mock}):
|
||||
assert dnsmasq.fullversion() == {
|
||||
"version": "C",
|
||||
"compile options": ["G", "H", "I"],
|
||||
}
|
||||
|
||||
|
||||
def test_set_config():
|
||||
"""
|
||||
test to show installed version of dnsmasq.
|
||||
"""
|
||||
mock = MagicMock(return_value={"conf-dir": "A"})
|
||||
with patch.object(dnsmasq, "get_config", mock):
|
||||
mock = MagicMock(return_value=[".", "~", "bak", "#"])
|
||||
with patch.object(os, "listdir", mock):
|
||||
assert dnsmasq.set_config() == {}
|
||||
|
||||
|
||||
def test_set_config_filter_pub_kwargs():
|
||||
"""
|
||||
Test that the kwargs returned from running the set_config function
|
||||
do not contain the __pub that may have been passed through in **kwargs.
|
||||
"""
|
||||
with patch(
|
||||
"salt.modules.dnsmasq.get_config", MagicMock(return_value={"conf-dir": "A"})
|
||||
):
|
||||
mock_domain = "local"
|
||||
mock_address = "/some-test-address.local/8.8.4.4"
|
||||
with patch.dict(dnsmasq.__salt__, {"file.append": MagicMock()}):
|
||||
ret = dnsmasq.set_config(
|
||||
follow=False,
|
||||
domain=mock_domain,
|
||||
address=mock_address,
|
||||
__pub_pid=8184,
|
||||
__pub_jid=20161101194639387946,
|
||||
__pub_tgt="salt-call",
|
||||
)
|
||||
assert ret == {"domain": mock_domain, "address": mock_address}
|
||||
|
||||
|
||||
def test_get_config():
|
||||
"""
|
||||
test to dumps all options from the config file.
|
||||
"""
|
||||
mock = MagicMock(return_value={"conf-dir": "A"})
|
||||
with patch.object(dnsmasq, "get_config", mock):
|
||||
mock = MagicMock(return_value=[".", "~", "bak", "#"])
|
||||
with patch.object(os, "listdir", mock):
|
||||
assert dnsmasq.get_config() == {"conf-dir": "A"}
|
||||
|
||||
|
||||
def test_parse_dnsmasq_no_file():
|
||||
"""
|
||||
Tests that a CommandExecutionError is when a filename that doesn't exist is
|
||||
passed in.
|
||||
"""
|
||||
pytest.raises(CommandExecutionError, dnsmasq._parse_dnamasq, "filename")
|
||||
|
||||
|
||||
def test_parse_dnamasq():
|
||||
"""
|
||||
test for generic function for parsing dnsmasq files including includes.
|
||||
"""
|
||||
with patch("os.path.isfile", MagicMock(return_value=True)):
|
||||
text_file_data = textwrap.dedent(
|
||||
"""\
|
||||
line here
|
||||
second line
|
||||
A=B
|
||||
#"""
|
||||
)
|
||||
with patch("salt.utils.files.fopen", mock_open(read_data=text_file_data)):
|
||||
assert dnsmasq._parse_dnamasq("filename") == {
|
||||
"A": "B",
|
||||
"unparsed": ["line here\n", "second line\n"],
|
||||
}
|
||||
|
|
@ -1,106 +0,0 @@
|
|||
"""
|
||||
:codeauthor: Rupesh Tare <rupesht@saltstack.com>
|
||||
"""
|
||||
|
||||
import os
|
||||
import textwrap
|
||||
|
||||
import salt.modules.dnsmasq as dnsmasq
|
||||
from salt.exceptions import CommandExecutionError
|
||||
from tests.support.mixins import LoaderModuleMockMixin
|
||||
from tests.support.mock import MagicMock, mock_open, patch
|
||||
from tests.support.unit import TestCase
|
||||
|
||||
|
||||
class DnsmasqTestCase(TestCase, LoaderModuleMockMixin):
|
||||
"""
|
||||
TestCase for the salt.modules.at module
|
||||
"""
|
||||
|
||||
def setup_loader_modules(self):
|
||||
return {dnsmasq: {}}
|
||||
|
||||
def test_version(self):
|
||||
"""
|
||||
test to show installed version of dnsmasq.
|
||||
"""
|
||||
mock = MagicMock(return_value="A B C")
|
||||
with patch.dict(dnsmasq.__salt__, {"cmd.run": mock}):
|
||||
self.assertEqual(dnsmasq.version(), "C")
|
||||
|
||||
def test_fullversion(self):
|
||||
"""
|
||||
Test to Show installed version of dnsmasq and compile options.
|
||||
"""
|
||||
mock = MagicMock(return_value="A B C\nD E F G H I")
|
||||
with patch.dict(dnsmasq.__salt__, {"cmd.run": mock}):
|
||||
self.assertDictEqual(
|
||||
dnsmasq.fullversion(),
|
||||
{"version": "C", "compile options": ["G", "H", "I"]},
|
||||
)
|
||||
|
||||
def test_set_config(self):
|
||||
"""
|
||||
test to show installed version of dnsmasq.
|
||||
"""
|
||||
mock = MagicMock(return_value={"conf-dir": "A"})
|
||||
with patch.object(dnsmasq, "get_config", mock):
|
||||
mock = MagicMock(return_value=[".", "~", "bak", "#"])
|
||||
with patch.object(os, "listdir", mock):
|
||||
self.assertDictEqual(dnsmasq.set_config(), {})
|
||||
|
||||
def test_set_config_filter_pub_kwargs(self):
|
||||
"""
|
||||
Test that the kwargs returned from running the set_config function
|
||||
do not contain the __pub that may have been passed through in **kwargs.
|
||||
"""
|
||||
with patch(
|
||||
"salt.modules.dnsmasq.get_config", MagicMock(return_value={"conf-dir": "A"})
|
||||
):
|
||||
mock_domain = "local"
|
||||
mock_address = "/some-test-address.local/8.8.4.4"
|
||||
with patch.dict(dnsmasq.__salt__, {"file.append": MagicMock()}):
|
||||
ret = dnsmasq.set_config(
|
||||
follow=False,
|
||||
domain=mock_domain,
|
||||
address=mock_address,
|
||||
__pub_pid=8184,
|
||||
__pub_jid=20161101194639387946,
|
||||
__pub_tgt="salt-call",
|
||||
)
|
||||
self.assertEqual(ret, {"domain": mock_domain, "address": mock_address})
|
||||
|
||||
def test_get_config(self):
|
||||
"""
|
||||
test to dumps all options from the config file.
|
||||
"""
|
||||
mock = MagicMock(return_value={"conf-dir": "A"})
|
||||
with patch.object(dnsmasq, "get_config", mock):
|
||||
mock = MagicMock(return_value=[".", "~", "bak", "#"])
|
||||
with patch.object(os, "listdir", mock):
|
||||
self.assertDictEqual(dnsmasq.get_config(), {"conf-dir": "A"})
|
||||
|
||||
def test_parse_dnsmasq_no_file(self):
|
||||
"""
|
||||
Tests that a CommandExecutionError is when a filename that doesn't exist is
|
||||
passed in.
|
||||
"""
|
||||
self.assertRaises(CommandExecutionError, dnsmasq._parse_dnamasq, "filename")
|
||||
|
||||
def test_parse_dnamasq(self):
|
||||
"""
|
||||
test for generic function for parsing dnsmasq files including includes.
|
||||
"""
|
||||
with patch("os.path.isfile", MagicMock(return_value=True)):
|
||||
text_file_data = textwrap.dedent(
|
||||
"""\
|
||||
line here
|
||||
second line
|
||||
A=B
|
||||
#"""
|
||||
)
|
||||
with patch("salt.utils.files.fopen", mock_open(read_data=text_file_data)):
|
||||
self.assertDictEqual(
|
||||
dnsmasq._parse_dnamasq("filename"),
|
||||
{"A": "B", "unparsed": ["line here\n", "second line\n"]},
|
||||
)
|
||||
Loading…
Add table
Reference in a new issue