From 33ed315c856e2e505a56ebd933f29438d97fefb2 Mon Sep 17 00:00:00 2001 From: Loren Carvalho Date: Sat, 15 Aug 2015 21:04:51 -0700 Subject: [PATCH] fixed Packaing -> Packaging typo and added a couple comments on the setuptools/distutils abstract methods --- setup.py | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/setup.py b/setup.py index 8bc68a4e007..cb6047a153c 100755 --- a/setup.py +++ b/setup.py @@ -138,10 +138,14 @@ class WriteSaltVersion(Command): description = 'Write salt\'s hardcoded version file' def initialize_options(self): - pass + ''' + Abstract method that is required to be overwritten + ''' def finalize_options(self): - pass + ''' + Abstract method that is required to be overwritten + ''' def run(self): if not os.path.exists(SALT_VERSION_HARDCODED): @@ -160,15 +164,19 @@ class WriteSaltVersion(Command): # pylint: enable=E0602 -class WriteSaltSshPackaingFile(Command): +class WriteSaltSshPackagingFile(Command): description = 'Write salt\'s ssh packaging file' def initialize_options(self): - pass + ''' + Abstract method that is required to be overwritten + ''' def finalize_options(self): - pass + ''' + Abstract method that is required to be overwritten + ''' def run(self): if not os.path.exists(PACKAGED_FOR_SALT_SSH_FILE): @@ -316,7 +324,9 @@ class TestCommand(Command): self.runtests_opts = None def finalize_options(self): - pass + ''' + Abstract method that is required to be overwritten + ''' def run(self): from subprocess import Popen