Merge pull request #45672 from rallytime/bp-45667

Back-port #45667 to 2017.7.3
This commit is contained in:
Nicole Thomas 2018-01-25 09:04:53 -05:00 committed by GitHub
commit 2f303439b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -438,7 +438,7 @@ def refresh_db(root=None):
def install(name=None,
refresh=False,
sysupgrade=False,
sysupgrade=None,
pkgs=None,
sources=None,
**kwargs):
@ -478,7 +478,8 @@ def install(name=None,
sysupgrade
Whether or not to upgrade the system packages before installing.
If refresh is set to ``True`` but sysupgrade is not specified, ``-u`` will be
applied
Multiple Package Installation Options:
@ -516,9 +517,6 @@ def install(name=None,
{'<package>': {'old': '<old-version>',
'new': '<new-version>'}}
'''
refresh = salt.utils.is_true(refresh)
sysupgrade = salt.utils.is_true(sysupgrade)
try:
pkg_params, pkg_type = __salt__['pkg_resource.parse_targets'](
name, pkgs, sources, **kwargs
@ -545,9 +543,9 @@ def install(name=None,
cmd.extend(pkg_params)
elif pkg_type == 'repository':
cmd.append('-S')
if refresh:
if refresh is True:
cmd.append('-y')
if sysupgrade:
if sysupgrade is True or (sysupgrade is None and refresh is True):
cmd.append('-u')
cmd.extend(['--noprogressbar', '--noconfirm', '--needed'])
wildcards = []