Drop the cache-suffix from the setup-python-tools-scripts action

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>

.github/actions/setup-python-tools-scripts/action.yml

@@ -7,10 +7,6 @@ inputs:
     required: true
     type: string
     description: Seed used to invalidate caches
-  cache-suffix:
-    required: false
-    type: string
-    description: Seed used to invalidate caches
   cwd:
     type: string
     description: The directory the salt checkout is located in
@@ -42,8 +38,8 @@ runs:
       shell: bash
       run: |
         VENV_NAME_HASH=$(echo "${{ inputs.cache-prefix }}|${{ github.workflow }}|${{
-          steps.get-python-version.outputs.version-sha256sum }}|${{ hashFiles('requirements/**/*.txt', 'tools/**/*.py') }}${{
+          steps.get-python-version.outputs.version-sha256sum }}|${{
-          inputs.cache-suffix || '' }}"  | sha256sum | cut -d ' ' -f 1)
+          hashFiles('requirements/**/*.txt', 'tools/**/*.py') }}"  | sha256sum | cut -d ' ' -f 1)
         echo "TOOLS_VIRTUALENV_CACHE_SEED=$VENV_NAME_HASH" | tee -a "${GITHUB_ENV}"
         echo "venv-hash=$VENV_NAME_HASH" | tee -a "${GITHUB_OUTPUT}"
 

.github/workflows/build-deps-onedir-linux.yml

@@ -62,8 +62,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ inputs.cache-seed }}
+          cache-prefix: ${{ inputs.cache-seed }}-build-deps-linux-${{ matrix.arch }}
-          cache-suffix: build-deps-linux-${{ matrix.arch }}
 
       - name: Setup Relenv
         id: setup-relenv

.github/workflows/build-deps-onedir-macos.yml

@@ -64,8 +64,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ inputs.cache-seed }}
+          cache-prefix: ${{ inputs.cache-seed }}-build-deps-macos
-          cache-suffix: build-deps-macos
 
       - name: Setup Relenv
         id: setup-relenv

.github/workflows/build-deps-onedir-windows.yml

@@ -65,8 +65,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ inputs.cache-seed }}
+          cache-prefix: ${{ inputs.cache-seed }}-build-deps-windows-${{ matrix.arch }}
-          cache-suffix: build-deps-windows-${{ matrix.arch }}
 
       - name: Setup Relenv
         id: setup-relenv

.github/workflows/ci.yml

@@ -279,8 +279,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-changelog
-          cache-suffix: changelog
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -400,8 +399,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-build
-          cache-suffix: build
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -2741,8 +2739,7 @@ jobs:
         id: python-tools-scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-coverage
-          cache-suffix: coverage
 
       - name: Install Nox
         run: |

.github/workflows/nightly.yml

@@ -323,8 +323,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-changelog
-          cache-suffix: changelog
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -449,8 +448,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-build
-          cache-suffix: build
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -2802,8 +2800,7 @@ jobs:
         id: python-tools-scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-coverage
-          cache-suffix: coverage
 
       - name: Install Nox
         run: |

.github/workflows/scheduled.yml

@@ -313,8 +313,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-changelog
-          cache-suffix: changelog
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -434,8 +433,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-build
-          cache-suffix: build
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -2775,8 +2773,7 @@ jobs:
         id: python-tools-scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-coverage
-          cache-suffix: coverage
 
       - name: Install Nox
         run: |

.github/workflows/staging.yml

@@ -317,8 +317,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-changelog
-          cache-suffix: changelog
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -439,8 +438,7 @@ jobs:
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-build
-          cache-suffix: build
 
       - name: Setup Salt Version
         id: setup-salt-version

.github/workflows/templates/ci.yml.jinja

@@ -71,8 +71,7 @@
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-changelog
-          cache-suffix: changelog
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -218,8 +217,7 @@
       - name: Setup Python Tools Scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-build
-          cache-suffix: build
 
       - name: Setup Salt Version
         id: setup-salt-version
@@ -330,8 +328,7 @@
         id: python-tools-scripts
         uses: ./.github/actions/setup-python-tools-scripts
         with:
-          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}
+          cache-prefix: ${{ needs.prepare-workflow.outputs.cache-seed }}-coverage
-          cache-suffix: coverage
 
       - name: Install Nox
         run: |