mirror of
https://github.com/saltstack/salt.git
synced 2025-04-17 10:10:20 +00:00
Merge pull request #24891 from jayeshka/ssh_known_hosts-states-unit-test
adding states/ssh_known_hosts unit test case.
This commit is contained in:
Justin Findlay
commit
1650233be9
2 changed files with 178 additions and 1 deletions
|
|
@ -120,7 +120,7 @@ def present(
|
|||
hash_hostname=hash_hostname)
|
||||
if result['status'] == 'exists':
|
||||
return dict(ret,
|
||||
Gcomment='{0} already exists in {1}'.format(name, config))
|
||||
comment='{0} already exists in {1}'.format(name, config))
|
||||
elif result['status'] == 'error':
|
||||
return dict(ret, result=False, comment=result['error'])
|
||||
else: # 'updated'
|
||||
|
|
|
|||
177
tests/unit/states/ssh_known_hosts_test.py
Normal file
177
tests/unit/states/ssh_known_hosts_test.py
Normal file
|
|
@ -0,0 +1,177 @@
|
|||
# -*- coding: utf-8 -*-
|
||||
'''
|
||||
:codeauthor: :email:`Jayesh Kariya <jayeshk@saltstack.com>`
|
||||
'''
|
||||
# Import Python libs
|
||||
from __future__ import absolute_import
|
||||
|
||||
# Import Salt Testing Libs
|
||||
from salttesting import skipIf, TestCase
|
||||
from salttesting.mock import (
|
||||
NO_MOCK,
|
||||
NO_MOCK_REASON,
|
||||
MagicMock,
|
||||
patch
|
||||
)
|
||||
|
||||
from salttesting.helpers import ensure_in_syspath
|
||||
import os
|
||||
ensure_in_syspath('../../')
|
||||
|
||||
# Import Salt Libs
|
||||
from salt.states import ssh_known_hosts
|
||||
|
||||
ssh_known_hosts.__salt__ = {}
|
||||
ssh_known_hosts.__opts__ = {}
|
||||
|
||||
|
||||
@skipIf(NO_MOCK, NO_MOCK_REASON)
|
||||
class SshKnownHostsTestCase(TestCase):
|
||||
'''
|
||||
Test cases for salt.states.ssh_known_hosts
|
||||
'''
|
||||
# 'present' function tests: 1
|
||||
|
||||
def test_present(self):
|
||||
'''
|
||||
Test to verifies that the specified host is known by the specified user.
|
||||
'''
|
||||
name = 'github.com'
|
||||
user = 'root'
|
||||
key = '16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48'
|
||||
fingerprint = [key]
|
||||
|
||||
ret = {'name': name,
|
||||
'changes': {},
|
||||
'result': False,
|
||||
'comment': ''}
|
||||
|
||||
with patch.dict(ssh_known_hosts.__opts__, {'test': True}):
|
||||
with patch.object(os.path, 'isabs', MagicMock(return_value=False)):
|
||||
comt = ('If not specifying a "user", '
|
||||
'specify an absolute "config".')
|
||||
ret.update({'comment': comt})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name), ret)
|
||||
|
||||
comt = ('Specify either "key" or "fingerprint", not both.')
|
||||
ret.update({'comment': comt})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user, key=key,
|
||||
fingerprint=[key]),
|
||||
ret)
|
||||
|
||||
comt = ('Required argument "enc" if using "key" argument.')
|
||||
ret.update({'comment': comt})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user, key=key),
|
||||
ret)
|
||||
|
||||
mock = MagicMock(side_effect=['exists', 'add', 'update'])
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.check_known_host': mock}):
|
||||
comt = ('Host github.com is already in .ssh/known_hosts')
|
||||
ret.update({'comment': comt, 'result': True})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user), ret)
|
||||
|
||||
comt = ('Key for github.com is set to be'
|
||||
' added to .ssh/known_hosts')
|
||||
ret.update({'comment': comt, 'result': None})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user), ret)
|
||||
|
||||
comt = ('Key for github.com is set to be '
|
||||
'updated in .ssh/known_hosts')
|
||||
ret.update({'comment': comt})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user), ret)
|
||||
|
||||
with patch.dict(ssh_known_hosts.__opts__, {'test': False}):
|
||||
result = {'status': 'exists', 'error': ''}
|
||||
mock = MagicMock(return_value=result)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.set_known_host': mock}):
|
||||
comt = ('github.com already exists in .ssh/known_hosts')
|
||||
ret.update({'comment': comt, 'result': True})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user), ret)
|
||||
|
||||
result = {'status': 'error', 'error': ''}
|
||||
mock = MagicMock(return_value=result)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.set_known_host': mock}):
|
||||
ret.update({'comment': '', 'result': False})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user), ret)
|
||||
|
||||
result = {'status': 'updated', 'error': '',
|
||||
'new': {'fingerprint': fingerprint, 'key': key},
|
||||
'old': ''}
|
||||
mock = MagicMock(return_value=result)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.set_known_host': mock}):
|
||||
comt = ("{0}'s key saved to .ssh/known_hosts (key: {1})"
|
||||
.format(name, key))
|
||||
ret.update({'comment': comt, 'result': True,
|
||||
'changes': {'new': {'fingerprint': fingerprint,
|
||||
'key': key}, 'old': ''}})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user,
|
||||
key=key), ret)
|
||||
|
||||
comt = ("{0}'s key saved to .ssh/known_hosts (fingerprint: {1})"
|
||||
.format(name, fingerprint))
|
||||
ret.update({'comment': comt})
|
||||
self.assertDictEqual(ssh_known_hosts.present(name, user), ret)
|
||||
|
||||
# 'absent' function tests: 1
|
||||
|
||||
def test_absent(self):
|
||||
'''
|
||||
Test to verifies that the specified host is not known by the given user.
|
||||
'''
|
||||
name = 'github.com'
|
||||
user = 'root'
|
||||
|
||||
ret = {'name': name,
|
||||
'changes': {},
|
||||
'result': False,
|
||||
'comment': ''}
|
||||
|
||||
with patch.object(os.path, 'isabs', MagicMock(return_value=False)):
|
||||
comt = ('If not specifying a "user", '
|
||||
'specify an absolute "config".')
|
||||
ret.update({'comment': comt})
|
||||
self.assertDictEqual(ssh_known_hosts.absent(name), ret)
|
||||
|
||||
mock = MagicMock(return_value=False)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.get_known_host': mock}):
|
||||
comt = ('Host is already absent')
|
||||
ret.update({'comment': comt, 'result': True})
|
||||
self.assertDictEqual(ssh_known_hosts.absent(name, user), ret)
|
||||
|
||||
mock = MagicMock(return_value=True)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.get_known_host': mock}):
|
||||
with patch.dict(ssh_known_hosts.__opts__, {'test': True}):
|
||||
comt = ('Key for github.com is set to be'
|
||||
' removed from .ssh/known_hosts')
|
||||
ret.update({'comment': comt, 'result': None})
|
||||
self.assertDictEqual(ssh_known_hosts.absent(name, user), ret)
|
||||
|
||||
with patch.dict(ssh_known_hosts.__opts__, {'test': False}):
|
||||
result = {'status': 'error', 'error': ''}
|
||||
mock = MagicMock(return_value=result)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.rm_known_host': mock}):
|
||||
ret.update({'comment': '', 'result': False})
|
||||
self.assertDictEqual(ssh_known_hosts.absent(name, user),
|
||||
ret)
|
||||
|
||||
result = {'status': 'removed', 'error': '',
|
||||
'comment': 'removed'}
|
||||
mock = MagicMock(return_value=result)
|
||||
with patch.dict(ssh_known_hosts.__salt__,
|
||||
{'ssh.rm_known_host': mock}):
|
||||
ret.update({'comment': 'removed', 'result': True,
|
||||
'changes': {'new': None, 'old': True}})
|
||||
self.assertDictEqual(ssh_known_hosts.absent(name, user),
|
||||
ret)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
from integration import run_tests
|
||||
run_tests(SshKnownHostsTestCase, needs_daemon=False)
|
||||
Loading…
Add table
Reference in a new issue