saltstack/salt
1
0
Fork 0
mirror of https://github.com/saltstack/salt.git synced 2025-04-17 10:10:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Added unit tests reproducing issue

Browse source
This commit is contained in:
Jerzy Drozdz 2018-11-02 23:01:43 +01:00
parent 3ffa3921b7
commit 110f74f3ba
1 changed files with 60 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
tests/unit/modules/test_file.py
View file

@ -1526,6 +1526,37 @@ class FilemodLineTests(TestCase, LoaderModuleMockMixin):
expected = self._get_body(file_modified)
assert writelines_content[0] == expected, (writelines_content[0], expected)
@with_tempfile()
def test_line_insert_duplicate_ensure_before(self, name):
'''
Test for file.line for insertion ensuring the line is before
:return:
'''
cfg_content = '/etc/init.d/someservice restart'
file_content = os.linesep.join([
'#!/bin/bash',
'',
cfg_content,
'exit 0'
])
file_modified = os.linesep.join([
'#!/bin/bash',
'',
cfg_content,
'exit 0'
])
isfile_mock = MagicMock(side_effect=lambda x: True if x == name else DEFAULT)
with patch('os.path.isfile', isfile_mock), \
patch('os.stat', MagicMock(return_value=DummyStat())), \
patch('salt.utils.files.fopen',
mock_open(read_data=file_content)), \
patch('salt.utils.atomicfile.atomic_open',
mock_open()) as atomic_open_mock:
filemod.line(name, content=cfg_content, before='exit 0', mode='ensure')
# If file not modified no handlers in dict
assert atomic_open_mock.filehandles.get(name) is None
@with_tempfile()
def test_line_insert_ensure_before_first_line(self, name):
'''
@ -1600,6 +1631,35 @@ class FilemodLineTests(TestCase, LoaderModuleMockMixin):
expected = self._get_body(file_modified)
assert writelines_content[0] == expected, (writelines_content[0], expected)
@with_tempfile()
def test_line_insert_duplicate_ensure_after(self, name):
'''
Test for file.line for insertion ensuring the line is after
:return:
'''
cfg_content = 'exit 0'
file_content = os.linesep.join([
'#!/bin/bash',
'/etc/init.d/someservice restart',
cfg_content
])
file_modified = os.linesep.join([
'#!/bin/bash',
'/etc/init.d/someservice restart',
cfg_content
])
isfile_mock = MagicMock(side_effect=lambda x: True if x == name else DEFAULT)
with patch('os.path.isfile', isfile_mock), \
patch('os.stat', MagicMock(return_value=DummyStat())), \
patch('salt.utils.files.fopen',
mock_open(read_data=file_content)), \
patch('salt.utils.atomicfile.atomic_open',
mock_open()) as atomic_open_mock:
filemod.line(name, content=cfg_content, after='/etc/init.d/someservice restart', mode='ensure')
# If file not modified no handlers in dict
assert atomic_open_mock.filehandles.get(name) is None
@with_tempfile()
def test_line_insert_ensure_beforeafter_twolines(self, name):
'''