saltstack/salt
1
0
Fork 0
mirror of https://github.com/saltstack/salt.git synced 2025-04-16 09:40:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Do not try to uninstall unless downgrading
Some checks are pending
CI / Prepare Workflow Run (push) Waiting to run
Details
CI / Pre-Commit (push) Blocked by required conditions
Details
CI / Lint (push) Blocked by required conditions
Details
CI / NSIS Tests (push) Blocked by required conditions
Details
CI / Prepare Release: (push) Blocked by required conditions
Details
CI / Documentation (push) Blocked by required conditions
Details
CI / Build Source Tarball (push) Blocked by required conditions
Details
CI / Build Salt Onedir (push) Blocked by required conditions
Details
CI / Build Packages (push) Blocked by required conditions
Details
CI / CI Deps (push) Blocked by required conditions
Details
CI / Test Package (push) Blocked by required conditions
Details
CI / Test Salt (push) Blocked by required conditions
Details
CI / Combine Code Coverage (push) Blocked by required conditions
Details
CI / Set the Pipeline Exit Status (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Daniel A. Wozniak 2025-03-18 17:48:44 -07:00
parent d9934fccab
commit 07f5429db6
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/support/pkg.py
View file

@ -795,14 +795,15 @@ class SaltPkgInstall:
if self.file_ext == "msi":
# MSI can not be downgraded, we must remove the newer version
# before installing the old one.
ret = subprocess.run(
f"msiexec.exe /qn /x {pkg} /norestart",
shell=True, # nosec
check=False,
)
assert ret.returncode == 0
if downgrade:
# MSI can not be downgraded, we must remove the newer version
# before installing the old one.
ret = subprocess.run(
f"msiexec.exe /qn /x {pkg} /norestart",
shell=True, # nosec
check=False,
)
assert ret.returncode == 0
# self.proc.run always makes the command a list even when shell
# is true, meaning shell being true will never work correctly.