From 174bc0d191df5bfca2f79b58fe02b9273b18396c Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Thu, 12 Mar 2015 03:52:31 -0700 Subject: [PATCH 01/14] Support alternate (non bleeding edge) ubuntu PPAs. --- bootstrap-salt.sh | 49 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 40 insertions(+), 9 deletions(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 3abbc84..62c94e5 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -224,12 +224,14 @@ usage() { Installation types: - stable (default) + - stable [version] (ubuntu specific) - daily (ubuntu specific) - git Examples: - ${__ScriptName} - ${__ScriptName} stable + - ${__ScriptName} stable 2014.7 - ${__ScriptName} daily - ${__ScriptName} git - ${__ScriptName} git develop @@ -410,6 +412,20 @@ if [ "$ITYPE" = "git" ]; then GIT_REV="$1" shift fi +# If doing stable install, check if version specified +elif [ "$ITYPE" = "stable" ]; then + if [ "$#" -eq 0 ];then + STABLE_REV="latest" + else + __check_unparsed_options "$*" + if [ "$(echo "$1" | egrep '(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.2)')" = "" ]; then + STABLE_REV="$1" + shift + else + echo "Unknown stable version: $1 (valid: 1.6, 1.7, 2014.1, 2014.7, 2015.2, latest)" + exit 1 + fi + fi fi # Check for any unparsed arguments. Should be an error. @@ -1103,6 +1119,9 @@ fi if ([ "${DISTRO_NAME_L}" != "ubuntu" ] && [ "$ITYPE" = "daily" ]); then echoerror "${DISTRO_NAME} does not have daily packages support" exit 1 +elif ([ "${DISTRO_NAME_L}" != "ubuntu" ] && [ "$STABLE_REV" != "latest" ]); then + echoerror "${DISTRO_NAME} does have major version pegged packages support" + exit 1 fi # Only RedHat based distros have testing support @@ -1698,15 +1717,6 @@ install_ubuntu_deps() { __enable_universe_repository || return 1 - if [ "$DISTRO_MAJOR_VERSION" -gt 11 ] || ([ "$DISTRO_MAJOR_VERSION" -eq 11 ] && [ "$DISTRO_MINOR_VERSION" -gt 04 ]); then - # Above Ubuntu 11.04 add a -y flag - add-apt-repository -y ppa:saltstack/salt || return 1 - else - add-apt-repository ppa:saltstack/salt || return 1 - fi - - apt-get update - # Minimal systems might not have upstart installed, install it __apt_get_install_noinput upstart @@ -1757,6 +1767,27 @@ install_ubuntu_deps() { return 0 } +install_ubuntu_stable_deps() { + install_ubuntu_deps || return 1 + + STABLE_PPA="saltstack/salt" + # Alternate PPAs: salt16, salt17, salt2014-1, salt2014-7 + if [ "$(echo "$STABLE_REV" | egrep '(1\.6|1\.7))')" = "" ]; then + STABLE_PPA="$STABLE_PPA$(echo "$STABLE_REV" | tr -d .)" + elif [ "$(echo "$STABLE_REV" | egrep '(2014\.1|2014\.7|2015\.2)')" = "" ]; then + STABLE_PPA="$STABLE_PPA$(echo "$1" | tr . -)" + fi + + if [ "$DISTRO_MAJOR_VERSION" -gt 11 ] || ([ "$DISTRO_MAJOR_VERSION" -eq 11 ] && [ "$DISTRO_MINOR_VERSION" -gt 04 ]); then + # Above Ubuntu 11.04 add a -y flag + add-apt-repository -y "ppa:$STABLE_PPA" || return 1 + else + add-apt-repository "ppa:$STABLE_PPA" || return 1 + fi + + apt-get update +} + install_ubuntu_daily_deps() { install_ubuntu_deps || return 1 if [ "$DISTRO_MAJOR_VERSION" -ge 12 ]; then From b94df22a6f3661e6ef425aabeb9dba4ada74ef77 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Thu, 12 Mar 2015 03:56:11 -0700 Subject: [PATCH 02/14] Include testing in list of valid install types. --- bootstrap-salt.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 62c94e5..6500ac7 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -226,6 +226,7 @@ usage() { - stable (default) - stable [version] (ubuntu specific) - daily (ubuntu specific) + - testing (redhat specific) - git Examples: @@ -233,6 +234,7 @@ usage() { - ${__ScriptName} stable - ${__ScriptName} stable 2014.7 - ${__ScriptName} daily + - ${__ScriptName} testing - ${__ScriptName} git - ${__ScriptName} git develop - ${__ScriptName} git v0.17.0 From 72bc0bd9a9825cd4fd77bd5a0410535501c0aafc Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Thu, 12 Mar 2015 03:52:31 -0700 Subject: [PATCH 03/14] Support alternate (non bleeding edge) ubuntu PPAs. --- bootstrap-salt.sh | 49 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 40 insertions(+), 9 deletions(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 00daf99..abf268d 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -224,12 +224,14 @@ usage() { Installation types: - stable (default) + - stable [version] (ubuntu specific) - daily (ubuntu specific) - git Examples: - ${__ScriptName} - ${__ScriptName} stable + - ${__ScriptName} stable 2014.7 - ${__ScriptName} daily - ${__ScriptName} git - ${__ScriptName} git develop @@ -410,6 +412,20 @@ if [ "$ITYPE" = "git" ]; then GIT_REV="$1" shift fi +# If doing stable install, check if version specified +elif [ "$ITYPE" = "stable" ]; then + if [ "$#" -eq 0 ];then + STABLE_REV="latest" + else + __check_unparsed_options "$*" + if [ "$(echo "$1" | egrep '(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.2)')" = "" ]; then + STABLE_REV="$1" + shift + else + echo "Unknown stable version: $1 (valid: 1.6, 1.7, 2014.1, 2014.7, 2015.2, latest)" + exit 1 + fi + fi fi # Check for any unparsed arguments. Should be an error. @@ -1103,6 +1119,9 @@ fi if ([ "${DISTRO_NAME_L}" != "ubuntu" ] && [ "$ITYPE" = "daily" ]); then echoerror "${DISTRO_NAME} does not have daily packages support" exit 1 +elif ([ "${DISTRO_NAME_L}" != "ubuntu" ] && [ "$STABLE_REV" != "latest" ]); then + echoerror "${DISTRO_NAME} does have major version pegged packages support" + exit 1 fi # Only RedHat based distros have testing support @@ -1698,15 +1717,6 @@ install_ubuntu_deps() { __enable_universe_repository || return 1 - if [ "$DISTRO_MAJOR_VERSION" -gt 11 ] || ([ "$DISTRO_MAJOR_VERSION" -eq 11 ] && [ "$DISTRO_MINOR_VERSION" -gt 04 ]); then - # Above Ubuntu 11.04 add a -y flag - add-apt-repository -y ppa:saltstack/salt || return 1 - else - add-apt-repository ppa:saltstack/salt || return 1 - fi - - apt-get update - # Minimal systems might not have upstart installed, install it __apt_get_install_noinput upstart @@ -1757,6 +1767,27 @@ install_ubuntu_deps() { return 0 } +install_ubuntu_stable_deps() { + install_ubuntu_deps || return 1 + + STABLE_PPA="saltstack/salt" + # Alternate PPAs: salt16, salt17, salt2014-1, salt2014-7 + if [ "$(echo "$STABLE_REV" | egrep '(1\.6|1\.7))')" = "" ]; then + STABLE_PPA="$STABLE_PPA$(echo "$STABLE_REV" | tr -d .)" + elif [ "$(echo "$STABLE_REV" | egrep '(2014\.1|2014\.7|2015\.2)')" = "" ]; then + STABLE_PPA="$STABLE_PPA$(echo "$1" | tr . -)" + fi + + if [ "$DISTRO_MAJOR_VERSION" -gt 11 ] || ([ "$DISTRO_MAJOR_VERSION" -eq 11 ] && [ "$DISTRO_MINOR_VERSION" -gt 04 ]); then + # Above Ubuntu 11.04 add a -y flag + add-apt-repository -y "ppa:$STABLE_PPA" || return 1 + else + add-apt-repository "ppa:$STABLE_PPA" || return 1 + fi + + apt-get update +} + install_ubuntu_daily_deps() { install_ubuntu_deps || return 1 if [ "$DISTRO_MAJOR_VERSION" -ge 12 ]; then From f5376d036db0f2cf0296ec73dc139cfcdf21cb11 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Thu, 12 Mar 2015 03:56:11 -0700 Subject: [PATCH 04/14] Include testing in list of valid install types. --- bootstrap-salt.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index abf268d..eb3b6e8 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -226,6 +226,7 @@ usage() { - stable (default) - stable [version] (ubuntu specific) - daily (ubuntu specific) + - testing (redhat specific) - git Examples: @@ -233,6 +234,7 @@ usage() { - ${__ScriptName} stable - ${__ScriptName} stable 2014.7 - ${__ScriptName} daily + - ${__ScriptName} testing - ${__ScriptName} git - ${__ScriptName} git develop - ${__ScriptName} git v0.17.0 From 2efc2c414933bfc7a8b192c61cd9da1130eb2cc6 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Sat, 28 Mar 2015 21:36:10 -0700 Subject: [PATCH 05/14] Inverted test cases. --- bootstrap-salt.sh | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index eb3b6e8..60302a2 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -420,12 +420,12 @@ elif [ "$ITYPE" = "stable" ]; then STABLE_REV="latest" else __check_unparsed_options "$*" - if [ "$(echo "$1" | egrep '(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.2)')" = "" ]; then - STABLE_REV="$1" - shift - else + if [ "$(echo "$1" | egrep '^(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.2)$')" = "" ]; then echo "Unknown stable version: $1 (valid: 1.6, 1.7, 2014.1, 2014.7, 2015.2, latest)" exit 1 + else + STABLE_REV="$1" + shift fi fi fi @@ -1772,12 +1772,13 @@ install_ubuntu_deps() { install_ubuntu_stable_deps() { install_ubuntu_deps || return 1 - STABLE_PPA="saltstack/salt" # Alternate PPAs: salt16, salt17, salt2014-1, salt2014-7 - if [ "$(echo "$STABLE_REV" | egrep '(1\.6|1\.7))')" = "" ]; then - STABLE_PPA="$STABLE_PPA$(echo "$STABLE_REV" | tr -d .)" - elif [ "$(echo "$STABLE_REV" | egrep '(2014\.1|2014\.7|2015\.2)')" = "" ]; then - STABLE_PPA="$STABLE_PPA$(echo "$1" | tr . -)" + if [ ! "$(echo "$STABLE_REV" | egrep '^(1\.6|1\.7)$')" = "" ]; then + STABLE_PPA="saltstack/salt$(echo "$STABLE_REV" | tr -d .)" + elif [ ! "$(echo "$STABLE_REV" | egrep '^(2014\.1|2014\.7|2015\.2)$')" = "" ]; then + STABLE_PPA="saltstack/salt$(echo "$STABLE_REV" | tr . -)" + else + STABLE_PPA="saltstack/salt" fi if [ "$DISTRO_MAJOR_VERSION" -gt 11 ] || ([ "$DISTRO_MAJOR_VERSION" -eq 11 ] && [ "$DISTRO_MINOR_VERSION" -gt 04 ]); then From 6c4999450daeac05e9908b15fa8d83fc493c2d2a Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Sat, 28 Mar 2015 21:38:55 -0700 Subject: [PATCH 06/14] Error text fix. --- bootstrap-salt.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 60302a2..70dd2fe 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -1122,7 +1122,7 @@ if ([ "${DISTRO_NAME_L}" != "ubuntu" ] && [ "$ITYPE" = "daily" ]); then echoerror "${DISTRO_NAME} does not have daily packages support" exit 1 elif ([ "${DISTRO_NAME_L}" != "ubuntu" ] && [ "$STABLE_REV" != "latest" ]); then - echoerror "${DISTRO_NAME} does have major version pegged packages support" + echoerror "${DISTRO_NAME} does not have major version pegged packages support" exit 1 fi From 149f1e838fac1efda2124069460cc858a9f3fed2 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Wed, 6 May 2015 13:11:59 -0700 Subject: [PATCH 07/14] 2015.2 renamed 2015.5 --- bootstrap-salt.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 70dd2fe..57c567d 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -421,7 +421,7 @@ elif [ "$ITYPE" = "stable" ]; then else __check_unparsed_options "$*" if [ "$(echo "$1" | egrep '^(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.2)$')" = "" ]; then - echo "Unknown stable version: $1 (valid: 1.6, 1.7, 2014.1, 2014.7, 2015.2, latest)" + echo "Unknown stable version: $1 (valid: 1.6, 1.7, 2014.1, 2014.7, 2015.5, latest)" exit 1 else STABLE_REV="$1" From 7fc5adfb9f326a5604a1ff522c665bd1d08ddfb2 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 09:42:36 +0100 Subject: [PATCH 08/14] Lower required requests version dep. Use system requests package. --- bootstrap-salt.sh | 51 +++++++++++++++++++++++------------------------ 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 0a748fb..9b42472 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -208,7 +208,7 @@ _SALT_MINION_ID="null" # __SIMPLIFY_VERSION is mostly used in Solaris based distributions __SIMPLIFY_VERSION=$BS_TRUE _LIBCLOUD_MIN_VERSION="0.14.0" -_PY_REQUESTS_MIN_VERSION="2.4.3" +_PY_REQUESTS_MIN_VERSION="2.0" _EXTRA_PACKAGES="" _HTTP_PROXY="" __SALT_GIT_CHECKOUT_DIR=${BS_SALT_GIT_CHECKOUT_DIR:-/tmp/git/salt} @@ -1753,26 +1753,23 @@ install_ubuntu_deps() { # Need python-apt for managing packages via Salt __apt_get_install_noinput python-apt - if ([ "$DISTRO_MAJOR_VERSION" -gt 12 ] && [ "$DISTRO_MAJOR_VERSION" -lt 15 ]) || ([ "$DISTRO_MAJOR_VERSION" -eq 12 ] && [ "$DISTRO_MINOR_VERSION" -gt 03 ]); then - if [ "$_ENABLE_EXTERNAL_ZMQ_REPOS" -eq $BS_TRUE ]; then + if [ "$DISTRO_MAJOR_VERSION" -gt 12 ] || ([ "$DISTRO_MAJOR_VERSION" -eq 12 ] && [ "$DISTRO_MINOR_VERSION" -gt 03 ]); then + if ([ "$DISTRO_MAJOR_VERSION" -lt 15 ] && [ "$_ENABLE_EXTERNAL_ZMQ_REPOS" -eq $BS_TRUE ]); then echoinfo "Installing ZMQ>=4/PyZMQ>=14 from Chris Lea's PPA repository" add-apt-repository -y ppa:chris-lea/zeromq || return 1 apt-get update fi __apt_get_install_noinput python-requests __PIP_PACKAGES="" - elif [ "$DISTRO_MAJOR_VERSION" -lt 15 ]; then + else check_pip_allowed "You need to allow pip based installations (-P) in order to install the python package 'requests'" __apt_get_install_noinput python-setuptools python-pip # shellcheck disable=SC2089 - __PIP_PACKAGES="'requests>=$_PY_REQUESTS_MIN_VERSION'" - elif [ "$DISTRO_MAJOR_VERSION" -ge 15 ]; then - __apt_get_install_noinput python-requests - __PIP_PACKAGES="" + __PIP_PACKAGES="requests>=$_PY_REQUESTS_MIN_VERSION" fi # Additionally install procps and pciutils which allows for Docker boostraps. See 366#issuecomment-39666813 - __apt_get_install_noinput procps pciutils + __apt_get_install_noinput procps pciutils || return 1 if [ "$_INSTALL_CLOUD" -eq $BS_TRUE ]; then check_pip_allowed "You need to allow pip based installations (-P) in order to install 'apache-libcloud'" @@ -2053,8 +2050,8 @@ install_debian_deps() { __PACKAGES="procps pciutils" __PIP_PACKAGES="" - if [ "$DISTRO_MAJOR_VERSION" -lt 7 ]; then - # Both python-requests which is a hard dependency and apache-libcloud which is a soft dependency, under debian < 7 + if [ "$DISTRO_MAJOR_VERSION" -lt 6 ]; then + # Both python-requests which is a hard dependency and apache-libcloud which is a soft dependency, under debian < 6 # need to be installed using pip check_pip_allowed "You need to allow pip based installations (-P) in order to install the python 'requests' package" # Additionally install procps and pciutils which allows for Docker boostraps. See 366#issuecomment-39666813 @@ -2064,14 +2061,17 @@ install_debian_deps() { fi # shellcheck disable=SC2086 - __apt_get_install_noinput ${__PACKAGES} + __apt_get_install_noinput ${__PACKAGES} || return 1 if [ "$_INSTALL_CLOUD" -eq $BS_TRUE ]; then # shellcheck disable=SC2089 __PIP_PACKAGES="${__PIP_PACKAGES} 'apache-libcloud>=$_LIBCLOUD_MIN_VERSION'" fi - # shellcheck disable=SC2086,SC2090 - pip install -U ${__PIP_PACKAGES} + + if [ "${__PIP_PACKAGES}" != "" ]; then + # shellcheck disable=SC2086,SC2090 + pip install -U ${__PIP_PACKAGES} || return 1 + fi if [ "$_UPGRADE_SYS" -eq $BS_TRUE ]; then __apt_get_upgrade_noinput || return 1 @@ -2162,15 +2162,14 @@ _eof # Python requests is available through Squeeze backports # Additionally install procps and pciutils which allows for Docker boostraps. See 366#issuecomment-39666813 - __apt_get_install_noinput python-pip procps pciutils + __apt_get_install_noinput python-pip procps pciutils python-requests # Need python-apt for managing packages via Salt __apt_get_install_noinput python-apt if [ "$_INSTALL_CLOUD" -eq $BS_TRUE ]; then check_pip_allowed "You need to allow pip based installations (-P) in order to install apache-libcloud/requests" - __apt_get_install_noinput python-pip - pip install -U "apache-libcloud>=$_LIBCLOUD_MIN_VERSION 'requests>=$_PY_REQUESTS_MIN_VERSION'" + pip install -U "apache-libcloud>=$_LIBCLOUD_MIN_VERSION" fi @@ -2228,20 +2227,18 @@ install_debian_7_deps() { __apt_get_install_noinput -t wheezy-backports libzmq3 libzmq3-dev python-zmq python-apt || return 1 # Additionally install procps and pciutils which allows for Docker boostraps. See 366#issuecomment-39666813 __PACKAGES="procps pciutils" + # Also install python-requests + __PACKAGES="${__PACKAGES} python-requests" # shellcheck disable=SC2086 __apt_get_install_noinput ${__PACKAGES} || return 1 - check_pip_allowed "You need to allow pip based installations (-P) in order to install requests" - __PACKAGES="build-essential python-dev python-pip" - # shellcheck disable=SC2086 - __apt_get_install_noinput ${__PACKAGES} || return 1 - pip install -U "requests>=$_PY_REQUESTS_MIN_VERSION" - - if [ "$_INSTALL_CLOUD" -eq $BS_TRUE ]; then + __PACKAGES="build-essential python-dev python-pip" + # shellcheck disable=SC2086 + __apt_get_install_noinput ${__PACKAGES} || return 1 check_pip_allowed "You need to allow pip based installations (-P) in order to install apache-libcloud" - pip install -U "apache-libcloud>=$_LIBCLOUD_MIN_VERSION" + pip install -U "apache-libcloud>=$_LIBCLOUD_MIN_VERSION" || return 1 fi if [ "$_UPGRADE_SYS" -eq $BS_TRUE ]; then @@ -2299,6 +2296,8 @@ install_debian_8_deps() { # Additionally install procps and pciutils which allows for Docker boostraps. See 366#issuecomment-39666813 __PACKAGES="procps pciutils" + # Also install python-requests + __PACKAGES="${__PACKAGES} python-requests" # shellcheck disable=SC2086 __apt_get_install_noinput ${__PACKAGES} || return 1 @@ -2349,7 +2348,7 @@ install_debian_git_deps() { __REQUIRED_TORNADO="$(grep tornado "${__SALT_GIT_CHECKOUT_DIR}/requirements/base.txt")" if [ "${__REQUIRED_TORNADO}" != "" ]; then check_pip_allowed "You need to allow pip based installations (-P) in order to install the python package '${__REQUIRED_TORNADO}'" - pip install -U "'${__REQUIRED_TORNADO}'" + pip install -U "${__REQUIRED_TORNADO}" || return 1 fi fi From bf36a941b285c749fd7bf6fe2fef9fac88a15fb9 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 09:46:40 +0100 Subject: [PATCH 09/14] Update changes log --- ChangeLog | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ChangeLog b/ChangeLog index 4e76469..b40b020 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Version 2015.xx.xx: + * Lower required requests version dependency. Use system requests package where possible. + + Version 2015.05.04: * Fix the configuration path for FreeBSD. #567/#552. Thanks Ronald van Zantvoort(The-Loeki). + Fix non grouping support in POSIX sed. Thanks Ronald van Zantvoort(The-Loeki). From 33f08049de966d228a07e9c774c57a0165a2fdfa Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 09:55:55 +0100 Subject: [PATCH 10/14] Fixed some refs to the old 2015.2 --- bootstrap-salt.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 9b42472..0f76872 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -421,7 +421,7 @@ elif [ "$ITYPE" = "stable" ]; then STABLE_REV="latest" else __check_unparsed_options "$*" - if [ "$(echo "$1" | egrep '^(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.2)$')" = "" ]; then + if [ "$(echo "$1" | egrep '^(latest|1\.6|1\.7|2014\.1|2014\.7|2015\.5)$')" = "" ]; then echo "Unknown stable version: $1 (valid: 1.6, 1.7, 2014.1, 2014.7, 2015.5, latest)" exit 1 else @@ -1804,7 +1804,7 @@ install_ubuntu_stable_deps() { # Alternate PPAs: salt16, salt17, salt2014-1, salt2014-7 if [ ! "$(echo "$STABLE_REV" | egrep '^(1\.6|1\.7)$')" = "" ]; then STABLE_PPA="saltstack/salt$(echo "$STABLE_REV" | tr -d .)" - elif [ ! "$(echo "$STABLE_REV" | egrep '^(2014\.1|2014\.7|2015\.2)$')" = "" ]; then + elif [ ! "$(echo "$STABLE_REV" | egrep '^(2014\.1|2014\.7|2015\.5)$')" = "" ]; then STABLE_PPA="saltstack/salt$(echo "$STABLE_REV" | tr . -)" else STABLE_PPA="saltstack/salt" From 5d6b9ee207812ab1915027c62fdb8c34c761e3f3 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 09:56:45 +0100 Subject: [PATCH 11/14] Add Peter Tripp(@notpeter) to AUTHORS --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index f05a12e..9943ca9 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -60,6 +60,7 @@ Paul Brian lifeisstillgood paul@mikadosoftware.com Pavel Snagovsky paha Pedro Algarvio s0undt3ch pedro@algarvio.me Pedro Paulo pedropaulovc +Peter Tripp notpeter ptonelli ptonelli Raymond Barbiero visualphoenix Roberto Aguilar rca roberto@baremetal.io From 12102d2b7f97644cd3a5fc4ecc6d7bdf782790c3 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 09:57:49 +0100 Subject: [PATCH 12/14] Update changes log --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index b40b020..fe732cc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,6 @@ Version 2015.xx.xx: * Lower required requests version dependency. Use system requests package where possible. + * Allow Ubuntu alternate ppas. Thanks Peter Tripp(notpeter). #563 Version 2015.05.04: From 479adb8fb7ee7f741500760998d0ef3f6c1e5301 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 10:01:40 +0100 Subject: [PATCH 13/14] Bump version for v2015.05.07 stable release --- ChangeLog | 3 +-- bootstrap-salt.sh | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index fe732cc..1f5d7bb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,7 @@ -Version 2015.xx.xx: +Version 2015.05.07: * Lower required requests version dependency. Use system requests package where possible. * Allow Ubuntu alternate ppas. Thanks Peter Tripp(notpeter). #563 - Version 2015.05.04: * Fix the configuration path for FreeBSD. #567/#552. Thanks Ronald van Zantvoort(The-Loeki). + Fix non grouping support in POSIX sed. Thanks Ronald van Zantvoort(The-Loeki). diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 0f76872..1b0bd4a 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -17,7 +17,7 @@ # CREATED: 10/15/2012 09:49:37 PM WEST #====================================================================================================================== set -o nounset # Treat unset variables as an error -__ScriptVersion="2015.05.04" +__ScriptVersion="2015.05.07" __ScriptName="bootstrap-salt.sh" #====================================================================================================================== From 1c38687f05e37b6d7da4cbdbf4d87e33d03c7475 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Thu, 7 May 2015 16:31:21 +0100 Subject: [PATCH 14/14] Fix Debian related issue when installing from git --- bootstrap-salt.sh | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/bootstrap-salt.sh b/bootstrap-salt.sh index 1b0bd4a..8dd027a 100755 --- a/bootstrap-salt.sh +++ b/bootstrap-salt.sh @@ -2379,14 +2379,17 @@ install_debian_git_deps() { install_debian_6_git_deps() { install_debian_6_deps || return 1 if [ "$_PIP_ALLOWED" -eq $BS_TRUE ]; then - easy_install -U Jinja2 || return 1 + __PACKAGES="build-essential lsb-release python python-dev python-pkg-resources python-crypto" + __PACKAGES="${__PACKAGES} python-m2crypto python-yaml msgpack-python python-pip" if [ "$(which git)" = "" ]; then - __apt_get_install_noinput git || return 1 + __PACKAGES="${__PACKAGES} git" fi - __apt_get_install_noinput lsb-release python python-pkg-resources python-crypto \ - python-m2crypto python-yaml msgpack-python python-pip || return 1 + # shellcheck disable=SC2086 + __apt_get_install_noinput ${__PACKAGES} || return 1 + + easy_install -U pyzmq Jinja2 || return 1 __git_clone_and_checkout || return 1 @@ -2460,13 +2463,6 @@ install_debian_8_stable() { } install_debian_git() { - if [ "$_PIP_ALLOWED" -eq $BS_TRUE ]; then - # Building pyzmq from source to build it against libzmq3. - # Should override current installation - # Using easy_install instead of pip because at least on Debian 6, - # there's no default virtualenv active. - easy_install -U pyzmq || return 1 - fi if [ -f "${__SALT_GIT_CHECKOUT_DIR}/salt/syspaths.py" ]; then python setup.py install --install-layout=deb --salt-config-dir="$_SALT_ETC_DIR" || return 1