Fixed git build issue with deps on RedHat family, and added more systemd containers to test against

2025-04-16 09:40:21 +00:00 · 2024-11-25 11:35:17 -07:00 · 2024-11-25 11:35:17 -07:00 · 344b942c28
commit 344b942c28
parent 320b3b787e
3 changed files with 96 additions and 66 deletions
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@ -180,6 +180,66 @@ jobs:



+  amazonlinux-2:
+    name: Amazon 2
+    if: github.event_name == 'push' || needs.collect-changed-files.outputs.run-tests == 'true'
+    uses: ./.github/workflows/test-linux.yml
+    needs:
+      - lint
+      - generate-actions-workflow
+    with:
+      distro-slug: amazonlinux-2
+      display-name: Amazon 2
+      container-slug: systemd-amazonlinux-2
+      timeout: 20
+      instances: '["stable-3006", "onedir-3006", "stable-3006-8", "stable-3007", "onedir-3007", "stable-3007-1", "latest", "default"]'
+
+
+  amazonlinux-2023:
+    name: Amazon 2023
+    if: github.event_name == 'push' || needs.collect-changed-files.outputs.run-tests == 'true'
+    uses: ./.github/workflows/test-linux.yml
+    needs:
+      - lint
+      - generate-actions-workflow
+    with:
+      distro-slug: amazonlinux-2023
+      display-name: Amazon 2023
+      container-slug: systemd-amazonlinux-2023
+      timeout: 20
+      instances: '["stable-3006", "onedir-3006", "stable-3006-8", "stable-3007", "onedir-3007", "stable-3007-1", "latest", "default"]'
+
+
+  debian-11:
+    name: Debian 11
+    if: github.event_name == 'push' || needs.collect-changed-files.outputs.run-tests == 'true'
+    uses: ./.github/workflows/test-linux.yml
+    needs:
+      - lint
+      - generate-actions-workflow
+    with:
+      distro-slug: debian-11
+      display-name: Debian 11
+      container-slug: systemd-debian-11
+      timeout: 20
+      instances: '["stable-3006", "onedir-3006", "stable-3006-8", "stable-3007", "onedir-3007", "stable-3007-1", "git-master", "latest", "default"]'
+
+
+  debian-12:
+    name: Debian 12
+    if: github.event_name == 'push' || needs.collect-changed-files.outputs.run-tests == 'true'
+    uses: ./.github/workflows/test-linux.yml
+    needs:
+      - lint
+      - generate-actions-workflow
+    with:
+      distro-slug: debian-12
+      display-name: Debian 12
+      container-slug: systemd-debian-12
+      timeout: 20
+      instances: '["git-3006", "stable-3007", "git-3007", "onedir-3007", "stable-3007-1", "git-master", "latest", "default"]'
+
+
  photon-5:
    name: Photon OS 5
    if: github.event_name == 'push' || needs.collect-changed-files.outputs.run-tests == 'true'
@ -222,7 +282,7 @@ jobs:
      display-name: Rocky Linux 9
      container-slug: systemd-rockylinux-9
      timeout: 20
-      instances: '["stable-3006", "onedir-3006", "stable-3006-8", "stable-3007", "onedir-3007", "stable-3007-1", "latest", "default"]'
+      instances: '["stable-3006", "git-3006", "onedir-3006", "stable-3006-8", "stable-3007", "git-3007", "onedir-3007", "stable-3007-1", "git-master", "latest", "default"]'


  ubuntu-2204:
@ -237,7 +297,7 @@ jobs:
      display-name: Ubuntu 22.04
      container-slug: systemd-ubuntu-22.04
      timeout: 20
-      instances: '["stable-3006", "onedir-3006", "stable-3006-8", "stable-3007", "onedir-3007", "stable-3007-1", "git-master", "latest", "default"]'
+      instances: '["stable-3006", "git-3006", "onedir-3006", "stable-3006-8", "stable-3007", "git-3007", "onedir-3007", "stable-3007-1", "git-master", "latest", "default"]'


  set-pipeline-exit-status:
@ -252,6 +312,10 @@ jobs:
      - macos-13
      - macos-14
      - windows-2022
+      - amazonlinux-2
+      - amazonlinux-2023
+      - debian-11
+      - debian-12
      - photon-5
      - rockylinux-8
      - rockylinux-9
--- a/.github/workflows/templates/generate.py
+++ b/.github/workflows/templates/generate.py
@ -18,6 +18,10 @@ os.chdir(os.path.abspath(os.path.dirname(__file__)))
 #    "ubuntu-2004",
 #    "ubuntu-2404",
 LINUX_DISTROS = [
+    "amazonlinux-2",
+    "amazonlinux-2023",
+    "debian-11",
+    "debian-12",
    "photon-5",
    "rockylinux-8",
    "rockylinux-9",
@ -36,17 +40,16 @@ OSX = [

 # only test against current containers with systemd
 # will add these when they become available with systemd
-#    "amazonlinux-2",
-#    "amazonlinux-2023",
-#    "centos-stream9",
-#    "debian-11",
-#    "debian-12",
 #    "debian-13",
 #    "fedora-40",
 #    "photon-4",
 #    "ubuntu-2004",
 #    "ubuntu-2404",
 STABLE_DISTROS = [
+    "amazonlinux-2",
+    "amazonlinux-2023",
+    "debian-11",
+    "debian-12",
    "photon-5",
    "rockylinux-8",
    "rockylinux-9",
@ -55,16 +58,16 @@ STABLE_DISTROS = [

 # only test against current containers with systemd
 # will add these when they become available with systemd
-#    "amazonlinux-2",
-#    "amazonlinux-2023",
-#    "debian-11",
-#    "debian-12",
 #    "debian-13",
 #    "fedora-40",
 #    "photon-4",
 #    "ubuntu-2004",
 #    "ubuntu-2404",
 ONEDIR_DISTROS = [
+    "amazonlinux-2",
+    "amazonlinux-2023",
+    "debian-11",
+    "debian-12",
    "photon-5",
    "rockylinux-8",
    "rockylinux-9",
@ -75,12 +78,12 @@ ONEDIR_DISTROS = [
 # will add these when they become available with systemd
 #    "amazonlinux-2",
 #    "amazonlinux-2023",
-#    "debian-12",
 #    "photon-4",
 #    "photon-5",
-#    "rockylinux-9",
+#    "rockylinux-8",
 #    "ubuntu-2404",
 ONEDIR_RC_DISTROS = [
+    "debian-12",
    "photon-5",
    "rockylinux-9",
    "ubuntu-2204",
@ -97,41 +100,41 @@ BLACKLIST_3007 = [
    "photon-5",
 ]

+#    "debian-12",
+#    "rockylinux-9",
+#    "ubuntu-2204",
 BLACKLIST_GIT_3006 = [
    "amazonlinux-2",
    "amazonlinux-2023",
    "debian-11",
-    "debian-12",
    "fedora-40",
    "photon-4",
    "photon-5",
-    "rockylinux-9",
    "ubuntu-2004",
-    "ubuntu-2204",
    "ubuntu-2404",
 ]

+#    "debian-12",
+#    "rockylinux-9",
+#    "ubuntu-2204",
 BLACKLIST_GIT_3007 = [
    "amazonlinux-2",
    "amazonlinux-2023",
    "debian-11",
-    "debian-12",
    "debian-13",
    "fedora-40",
    "photon-4",
    "photon-5",
-    "rockylinux-9",
    "ubuntu-2004",
-    "ubuntu-2204",
    "ubuntu-2404",
 ]

+##    "rockylinux-9",
 BLACKLIST_GIT_MASTER = [
    "amazonlinux-2",
    "amazonlinux-2023",
    "photon-4",
    "photon-5",
-    "rockylinux-9",
 ]

 SALT_VERSIONS = [
--- a/bootstrap-salt.sh
+++ b/bootstrap-salt.sh
@ -26,7 +26,7 @@
 #======================================================================================================================
 set -o nounset                              # Treat unset variables as an error

-__ScriptVersion="2024.11.22"
+__ScriptVersion="2024.11.21"
 __ScriptName="bootstrap-salt.sh"

 __ScriptFullName="$0"
@ -314,9 +314,6 @@ __usage() {

  Usage :  ${__ScriptName} [options] <install-type> [install-type-args]

-
-  Usage :  bootstrap-salt.sh [options] <install-type> [install-type-args]
-
  Installation types:
    - stable               Install latest stable release. This is the default
                           install type
@ -354,6 +351,7 @@ __usage() {
    - ${__ScriptName} onedir_rc
    - ${__ScriptName} onedir_rc 3008

+
  Options:
    -a  Pip install all Python pkg dependencies for Salt. Requires -V to install
        all pip pkgs into the virtualenv.
@ -375,7 +373,7 @@ __usage() {
    -f  Force shallow cloning for git installations.
        This may result in an "n/a" in the version number.
    -F  Allow copied files to overwrite existing (config, init.d, etc)
-    -g  Salt Git repository URL. Default: https://github.com/saltstack/salt.git
+    -g  Salt Git repository URL. Default: ${_SALTSTACK_REPO_URL}
    -h  Display this message
    -H  Use the specified HTTP proxy for all download URLs (including https://).
        For example: http://myproxy.example.com:3128
@ -421,7 +419,7 @@ __usage() {
        "packages.broadcom.com". If -R is passed, -r is also set. Currently only
        works on CentOS/RHEL and Debian based distributions and macOS.
    -s  Sleep time used when waiting for daemons to start, restart and when
-        checking for the services running. Default: 3
+        checking for the services running. Default: ${__DEFAULT_SLEEP}
    -S  Also install salt-syndic
    -r  Disable all repository configuration performed by this script. This
        option assumes all necessary repository configuration is already present
@ -546,8 +544,8 @@ __exit_cleanup() {
            echodebug "Cleaning up the Salt Temporary Git Repository"
            # shellcheck disable=SC2164
            cd "${__SALT_GIT_CHECKOUT_PARENT_DIR}"
-            rm -rf "${_SALT_GIT_CHECKOUT_DIR}"
-            #rm -rf "${_SALT_GIT_CHECKOUT_DIR}/deps"
+            rm -fR "${_SALT_GIT_CHECKOUT_DIR}"
+            #rm -fR "${_SALT_GIT_CHECKOUT_DIR}/deps"
        else
            echowarn "Not cleaning up the Salt Temporary git repository on request"
            echowarn "Note that if you intend to re-run this script using the git approach, you might encounter some issues"
@ -603,7 +601,6 @@ fi
 echoinfo "Running version: ${__ScriptVersion}"
 echoinfo "Executed by: ${CALLER}"
 echoinfo "Command line: '${__ScriptFullName} ${__ScriptArgs}'"
-echowarn "Running the unstable version of ${__ScriptName}"

 # Defaults
 STABLE_REV="latest"
@ -2737,44 +2734,10 @@ __install_salt_from_repo() {
    __check_pip_allowed

    echodebug "Installed pip version: $(${_pip_cmd} --version)"
+    echodebug "Upgrading pip to latest, running '${_pip_cmd} install ${_PIP_INSTALL_ARGS} -U pip>=${_MINIMUM_PIP_VERSION}'"
+    ${_pip_cmd} install ${_PIP_INSTALL_ARGS} -v -U "pip>=${_MINIMUM_PIP_VERSION}"

-    CHECK_PIP_VERSION_SCRIPT=$(cat << EOM
-import sys
-try:
-    import pip
-    installed_pip_version=tuple([int(part.strip()) for part in pip.__version__.split('.') if part.isdigit()])
-    desired_pip_version=($(echo ${_MINIMUM_PIP_VERSION} | sed 's/\./, /g' ))
-    if installed_pip_version < desired_pip_version:
-        print('Desired pip version {!r} > Installed pip version {!r}'.format('.'.join(map(str, desired_pip_version)), '.'.join(map(str, installed_pip_version))))
-        sys.exit(1)
-    print('Desired pip version {!r} < Installed pip version {!r}'.format('.'.join(map(str, desired_pip_version)), '.'.join(map(str, installed_pip_version))))
-    sys.exit(0)
-except ImportError:
-    print('Failed to import pip')
-    sys.exit(1)
-EOM
-)
-    if ! ${_py_exe} -c "$CHECK_PIP_VERSION_SCRIPT"; then
-        # Upgrade pip to at least 1.2 which is when we can start using "python3 -m pip"
-        echodebug "Running '${_pip_cmd} install ${_PIP_INSTALL_ARGS} pip>=${_MINIMUM_PIP_VERSION}'"
-        ${_pip_cmd} install ${_PIP_INSTALL_ARGS} -v "pip>=${_MINIMUM_PIP_VERSION}"
-        sleep 1
-        echodebug "PATH: ${PATH}"
-        _pip_cmd="pip${_py_version}"
-        if ! __check_command_exists "${_pip_cmd}"; then
-            echodebug "The pip binary '${_pip_cmd}' was not found in PATH"
-            _pip_cmd="pip$(echo "${_py_version}" | cut -c -1)"
-            if ! __check_command_exists "${_pip_cmd}"; then
-                echodebug "The pip binary '${_pip_cmd}' was not found in PATH"
-                _pip_cmd="pip"
-                if ! __check_command_exists "${_pip_cmd}"; then
-                    echoerror "Unable to find a pip binary"
-                    return 1
-                fi
-            fi
-        fi
-        echodebug "Installed pip version: $(${_pip_cmd} --version)"
-    fi
+    echodebug "Upgraded pip version: $(${_pip_cmd} --version)"

    _setuptools_dep="setuptools>=${_MINIMUM_SETUPTOOLS_VERSION},<${_MAXIMUM_SETUPTOOLS_VERSION}"
    if [ "$_PY_MAJOR_VERSION" -ne 3 ]; then