The `test_conversion` job failed during the weekly testing:
* https://gitlab.com/myii/template-formula/-/jobs/2371193438
The `stderr` being:
```
/root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node:
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found
(required by /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node)
```
The following references led to this resolution:
* https://github.com/pre-commit/pre-commit/issues/2351
* https://stackoverflow.com/questions/71939099/bitbucket-pipeline-error-installing-pre-commit-ts-lint
As mentioned there:
> a few days ago node 18.x was released and the prebuilt binaries
> require a relatively-recent version of glibc
Which obviously isn't available on our current Bionic-based `dind` image,
i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'.
While debugging this situation locally, noticed that the use of a
relative `tmp/...` subdirectory was within the `template-formula`
directory itself -- so switched this to using `/tmp/...` instead.
The kitchen-salt provisionner have the `pillars_from_directories`
option to recusively copy directories under target pillar root.
This has 3 advantages:
- simplify `kitchen.yml`
- manage pillar assignment with standard salt targetting mechanism,
this avoid the dedicated `gentoo` suite (it could have been done
from `kitchen.yml` itself by the way)
- ease the test outside kitchen by running `salt-call` directly with
`--pillar-root` like:
```
salt-call --local --id test-minion.example.net \
--file-root=template-formula/ \
--pillar-root=template-formula/test/salt/pillar/ \
state.show_sls TEMPLATE
```
* pillar.example: remove settings for testing purpose.
* test/salt/pillar/top.sls: limit `gentoo` pillars based on `os_family`
grain.
* test/salt/pillar/defaults.sls: base pillar dedicated to tests.
* kitchen.yml (suites): remove the now useless `gentoo` suite.
Define `pillars_from_directories` to copy them under `pillar_root`.
Remove useless `pillars_from_files`.
* .gitlab-ci.yml: fix gentoo suite name
* .gitignore: do not ignore test pillar `top.sls`