From 34aae257e586dd3e1d8b093085a790381a8af656 Mon Sep 17 00:00:00 2001
From: Imran Iqbal <iqbalmy@hotmail.com>
Date: Thu, 21 Jun 2018 08:30:08 +0100
Subject: [PATCH] Allow configuration of cluster `name`, `locale` & `encoding`

---
 pillar.example            | 7 +++++++
 postgres/codenamemap.yaml | 7 ++++---
 postgres/defaults.yaml    | 5 +++++
 postgres/repo.yaml        | 1 +
 postgres/server/init.sls  | 9 ++++++++-
 5 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/pillar.example b/pillar.example
index 45d9c1e..24b0556 100644
--- a/pillar.example
+++ b/pillar.example
@@ -26,6 +26,13 @@ postgres:
     - postgresql-contrib
     - postgresql-plpython
 
+  # CLUSTER
+  # The default `encoding` is derived from the `locale` so not recommended
+  # to provide a value for it unless necessary
+  cluster:
+    locale: en_GB.UTF-8
+    # encoding: UTF8
+
   #'Alternatives system' priority incremental. 0 disables feature.
   linux:
     altpriority: 30
diff --git a/postgres/codenamemap.yaml b/postgres/codenamemap.yaml
index 2e488f3..58985a9 100644
--- a/postgres/codenamemap.yaml
+++ b/postgres/codenamemap.yaml
@@ -16,8 +16,9 @@
   {% else %}
     {% set fromrepo = name %}
   {% endif %}
-  {% set conf_dir = '/etc/postgresql/' ~ version ~ '/main' %}
-  {% set data_dir = '/var/lib/postgresql/' ~ version ~ '/main' %}
+  {% set cluster_name = repo.cluster_name %}
+  {% set conf_dir = '/etc/postgresql/{0}/{1}'.format(version, cluster_name) %}
+  {% set data_dir = '/var/lib/postgresql/{0}/{1}'.format(version, cluster_name) %}
 
 {{ codename|default(name, true) }}:
   # PostgreSQL packages are mostly downloaded from `main` repo component
@@ -29,7 +30,7 @@
   pkg: postgresql-{{ version }}
   pkg_client: postgresql-client-{{ version }}
   prepare_cluster:
-    pgcommand: pg_createcluster {{ version }} main -d
+    pgcommand: pg_createcluster {{ version }} {{ cluster_name }} -d
     user: root
 
 {% endmacro %}
diff --git a/postgres/defaults.yaml b/postgres/defaults.yaml
index 6dcf50d..2f470fb 100644
--- a/postgres/defaults.yaml
+++ b/postgres/defaults.yaml
@@ -21,6 +21,11 @@ postgres:
     user: postgres
     env: []
 
+  cluster:
+    name: main    # Debian-based only
+    locale: ''    # Defaults to `C`
+    encoding: ''  # Defaults to `SQL_ASCII` if `locale` not provided
+
   conf_dir: /var/lib/pgsql/data
   data_dir: /var/lib/pgsql/data
   conf_dir_mode: '0700'
diff --git a/postgres/repo.yaml b/postgres/repo.yaml
index 51675e1..5d5887f 100644
--- a/postgres/repo.yaml
+++ b/postgres/repo.yaml
@@ -6,6 +6,7 @@
 use_upstream_repo: {{ salt['pillar.get']('postgres:use_upstream_repo', defaults.postgres.use_upstream_repo) }}
 version: {{ salt['pillar.get']('postgres:version', defaults.postgres.version) }}
 fromrepo: {{ salt['pillar.get']('postgres:fromrepo', defaults.postgres.fromrepo) }}
+cluster_name: {{ salt['pillar.get']('postgres:cluster:name', defaults.postgres.cluster.name) }}
 
 #Early lookup for system user on MacOS
 {% if grains.os == 'MacOS' %}
diff --git a/postgres/server/init.sls b/postgres/server/init.sls
index 987391e..417d279 100644
--- a/postgres/server/init.sls
+++ b/postgres/server/init.sls
@@ -76,7 +76,14 @@ postgresql-cluster-prepared:
     - name: {{ postgres.prepare_cluster.command }}
     - unless: {{ postgres.prepare_cluster.test }}
  {%- else %}
-    - name: {{ postgres.prepare_cluster.pgcommand }} {{ postgres.data_dir }}
+    {%- set cc_cmd = '{0} {1}'.format(postgres.prepare_cluster.pgcommand, postgres.data_dir) %}
+    {%- if postgres.cluster.locale %}
+      {%- set cc_cmd = '{0} --locale={1}'.format(cc_cmd, postgres.cluster.locale) %}
+    {%- endif %}
+    {%- if postgres.cluster.encoding %}
+      {%- set cc_cmd = '{0} --encoding={1}'.format(cc_cmd, postgres.cluster.encoding) %}
+    {%- endif %}
+    - name: {{ cc_cmd }}
     - unless: test -f {{ postgres.data_dir }}/{{ postgres.prepare_cluster.pgtestfile }}
  {%- endif %}
     - cwd: /