The indentation in servers.sls was unclear and made following the
control flow much harder.
Fix that by correctly indenting.
Drive-By: Change {% to {%- no-line-break opening tags for variable logic
Current default version for FreeBSD is MySQL 5.7, also python 2.x is
deprecated and should be removed any time soon.
FreeBSD uses the `mysql_install_db` which generates a temporary root
password upon the first start. To the best of my understanding I haven't
seen any code in the formula that handles this method. So I added
a FreeBSD-scpecific block for initialization. While here, create
`/var/log/mysql` without which the server won't start if it doesn't
exist.
Co-authored-by: Geraud CONTINSOUZAS <geraud.continsouzas@skazy.nc>
```bash
In mysql/files/mac_shortcut.sh line 5:
if [[ -e "{{ home }}/{{ user }}/Desktop/{{ app }}" ]] && [[ "${1}" -eq "remove" ]]
^------^ SC2154: remove is referenced but not assigned.
In mysql/files/mac_shortcut.sh line 8:
elif [[ -e "{{ dir }}/{{ app ~ '.app' if suffix else app }}" ]] && [[ "${1}" -eq "add" ]]
^---^ SC2154: add is referenced but not assigned.
```
```bash
Examining mysql/user.sls of type state
[202] Jinja statement should have spaces before and after: {% statement %}
mysql/user.sls:35
{% set state_id = 'mysql_user_' ~ name ~ '_' ~ host%}
[206] Jinja variables should have spaces before and after: {{ var_name }}
mysql/user.sls:100
- grant: {{db['grants']|join(",")}}
```
```bash
Examining mysql/server.sls of type state
[206] Jinja variables should have spaces before and after: {{ var_name }}
mysql/server.sls:119
- creates: {{ mysql_datadir}}/mysql/
[206] Jinja variables should have spaces before and after: {{ var_name }}
mysql/server.sls:141
- creates: {{ mysql_datadir}}/mysql/
```
* Semi-automated using https://github.com/myii/ssf-formula/pull/27
* Fix (or ignore) errors shown below:
```bash
mysql-formula$ yamllint -s .
./mysql/osfamilymap.yaml
46:14 error empty value in block mapping (empty-values)
66:14 error empty value in block mapping (empty-values)
67:14 error empty value in block mapping (empty-values)
68:16 error empty value in block mapping (empty-values)
69:17 error empty value in block mapping (empty-values)
70:16 error empty value in block mapping (empty-values)
87:7 error empty value in block mapping (empty-values)
216:14 error empty value in block mapping (empty-values)
217:17 error empty value in block mapping (empty-values)
./mysql/defaults.yaml
29:10 error empty value in block mapping (empty-values)
30:11 error empty value in block mapping (empty-values)
```
* Semi-automated using `ssf-formula` (v0.5.0)
* Fix (or ignore) errors shown below:
```bash
mysql-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:")
./mysql/osfamilymap.yaml
4:1 warning missing document start "---" (document-start)
5:6 error syntax error: found character '%' that cannot start any token
94:17 error trailing spaces (trailing-spaces)
191:89 error line too long (90 > 88 characters) (line-length)
./mysql/defaults.yaml
3:1 warning missing document start "---" (document-start)
7:4 error syntax error: found character '%' that cannot start any token
44:89 error line too long (93 > 88 characters) (line-length)
51:89 error line too long (111 > 88 characters) (line-length)
58:89 error line too long (104 > 88 characters) (line-length)
65:89 error line too long (103 > 88 characters) (line-length)
71:89 error line too long (95 > 88 characters) (line-length)
77:89 error line too long (102 > 88 characters) (line-length)
83:89 error line too long (101 > 88 characters) (line-length)
86:89 error line too long (95 > 88 characters) (line-length)
90:89 error line too long (95 > 88 characters) (line-length)
./mysql/supported_sections.yaml
2:2 error syntax error: found character '%' that cannot start any token
./mysql/osmap.yaml
4:4 error syntax error: found character '%' that cannot start any token
7:89 error line too long (96 > 88 characters) (line-length)
8:89 error line too long (97 > 88 characters) (line-length)
pillar.example
1:1 warning missing document start "---" (document-start)
36:8 error wrong indentation: expected 8 but found 7 (indentation)
77:16 warning truthy value should be one of [false, true] (truthy)
80:13 warning truthy value should be one of [false, true] (truthy)
83:13 warning truthy value should be one of [false, true] (truthy)
85:13 warning truthy value should be one of [false, true] (truthy)
89:13 warning truthy value should be one of [false, true] (truthy)
96:13 warning truthy value should be one of [false, true] (truthy)
112:19 warning truthy value should be one of [false, true] (truthy)
117:17 warning too few spaces before comment (comments)
118:12 warning truthy value should be one of [false, true] (truthy)
119:17 warning truthy value should be one of [false, true] (truthy)
130:25 warning truthy value should be one of [false, true] (truthy)
131:19 warning truthy value should be one of [false, true] (truthy)
153:16 warning truthy value should be one of [false, true] (truthy)
166:14 warning truthy value should be one of [false, true] (truthy)
171:18 warning truthy value should be one of [false, true] (truthy)
172:89 error line too long (93 > 88 characters) (line-length)
175:18 warning truthy value should be one of [false, true] (truthy)
176:89 error line too long (111 > 88 characters) (line-length)
179:18 warning truthy value should be one of [false, true] (truthy)
179:26 warning missing starting space in comment (comments)
180:89 error line too long (104 > 88 characters) (line-length)
183:18 warning truthy value should be one of [false, true] (truthy)
183:26 warning missing starting space in comment (comments)
184:89 error line too long (103 > 88 characters) (line-length)
187:18 warning truthy value should be one of [false, true] (truthy)
187:26 warning missing starting space in comment (comments)
188:89 error line too long (95 > 88 characters) (line-length)
191:18 warning truthy value should be one of [false, true] (truthy)
191:26 warning missing starting space in comment (comments)
192:89 error line too long (102 > 88 characters) (line-length)
195:18 warning truthy value should be one of [false, true] (truthy)
195:26 warning missing starting space in comment (comments)
196:89 error line too long (101 > 88 characters) (line-length)
199:18 warning truthy value should be one of [false, true] (truthy)
199:26 warning missing starting space in comment (comments)
200:89 error line too long (95 > 88 characters) (line-length)
203:18 warning truthy value should be one of [false, true] (truthy)
203:26 warning missing starting space in comment (comments)
204:89 error line too long (95 > 88 characters) (line-length)
207:18 warning truthy value should be one of [false, true] (truthy)
207:26 warning missing starting space in comment (comments)
211:18 warning truthy value should be one of [false, true] (truthy)
211:26 warning missing starting space in comment (comments)
214:1 error too many blank lines (1 > 0) (empty-lines)
test/salt/pillar/mysql.sls
1:1 warning missing document start "---" (document-start)
36:8 error wrong indentation: expected 8 but found 7 (indentation)
77:16 warning truthy value should be one of [false, true] (truthy)
80:13 warning truthy value should be one of [false, true] (truthy)
82:13 warning truthy value should be one of [false, true] (truthy)
84:13 warning truthy value should be one of [false, true] (truthy)
88:13 warning truthy value should be one of [false, true] (truthy)
95:13 warning truthy value should be one of [false, true] (truthy)
111:19 warning truthy value should be one of [false, true] (truthy)
152:16 warning truthy value should be one of [false, true] (truthy)
165:14 warning truthy value should be one of [false, true] (truthy)
170:18 warning truthy value should be one of [false, true] (truthy)
171:89 error line too long (93 > 88 characters) (line-length)
174:18 warning truthy value should be one of [false, true] (truthy)
175:89 error line too long (111 > 88 characters) (line-length)
178:18 warning truthy value should be one of [false, true] (truthy)
178:26 warning missing starting space in comment (comments)
179:89 error line too long (104 > 88 characters) (line-length)
182:18 warning truthy value should be one of [false, true] (truthy)
182:26 warning missing starting space in comment (comments)
183:89 error line too long (103 > 88 characters) (line-length)
186:18 warning truthy value should be one of [false, true] (truthy)
186:26 warning missing starting space in comment (comments)
187:89 error line too long (95 > 88 characters) (line-length)
190:18 warning truthy value should be one of [false, true] (truthy)
190:26 warning missing starting space in comment (comments)
191:89 error line too long (102 > 88 characters) (line-length)
194:18 warning truthy value should be one of [false, true] (truthy)
194:26 warning missing starting space in comment (comments)
195:89 error line too long (101 > 88 characters) (line-length)
198:18 warning truthy value should be one of [false, true] (truthy)
198:26 warning missing starting space in comment (comments)
199:89 error line too long (95 > 88 characters) (line-length)
202:18 warning truthy value should be one of [false, true] (truthy)
202:26 warning missing starting space in comment (comments)
203:89 error line too long (95 > 88 characters) (line-length)
206:18 warning truthy value should be one of [false, true] (truthy)
206:26 warning missing starting space in comment (comments)
210:18 warning truthy value should be one of [false, true] (truthy)
210:26 warning missing starting space in comment (comments)
213:1 error too many blank lines (1 > 0) (empty-lines)
```
I've added support for the official mysql 8.0 packages and the relevant repositories.
Package names are mysql-community-server and mysql-community-client.
I know the repo setting breaks convention a bit but it is compulsory so I'm not sure how else to properly include it.
This change requires the salt pull request I created https://github.com/saltstack/salt/pull/51240 to be able to grant users.
